Move Mailbox from cc to gpu, and its traits to gpu/ipc

Move Mailbox from cc to gpu, and its traits to gpu/ipc

Mailbox is safer to IPC than coaxing it into a string, because otherwise we need
to validate the size when coming from untrusted sources.

This is to enable passing Mailbox through IPC without having to depend on cc.
Among others I will need it to move Pepper to mailboxes, and pepper can't depend
on cc.

BUG=164095
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186006

[piman, 2013-03-02 00:39:04]

This is on top of 12371002 (mailbox output surface).

jamesr: cc/
sievers: content/
apatrick: gpu/
jschuh: IPC (this just moves the struct around).

[apatrick_chromium, 2013-03-02 01:59:19]

gpu/ LGTM

[jamesr, 2013-03-02 02:09:36]

cc/ and content/renderer/ lgtm

[jschuh, 2013-03-02 06:51:35]

lgtm. no significant change in ipc surface.

[no sievers, 2013-03-04 18:27:28]

lgtm. yes, I kept putting that off, and we should really share this definition.

[no sievers, 2013-03-04 18:27:40]

https://codereview.chromium.org/12378053/diff/1/gpu/command_buffer/common/mai...
File gpu/command_buffer/common/mailbox.cc (right):

https://codereview.chromium.org/12378053/diff/1/gpu/command_buffer/common/mai...
gpu/command_buffer/common/mailbox.cc:5: #include "../common/mailbox.h"
here and below: 'gpu/command_buffer/' instead of '../'?

https://codereview.chromium.org/12378053/diff/1/gpu/ipc/gpu_command_buffer_tr...
File gpu/ipc/gpu_command_buffer_traits.cc (right):

https://codereview.chromium.org/12378053/diff/1/gpu/ipc/gpu_command_buffer_tr...
gpu/ipc/gpu_command_buffer_traits.cc:47: PickleIterator* iter,
nit: alignment

[piman, 2013-03-04 18:52:05]

https://codereview.chromium.org/12378053/diff/1/gpu/command_buffer/common/mai...
File gpu/command_buffer/common/mailbox.cc (right):

https://codereview.chromium.org/12378053/diff/1/gpu/command_buffer/common/mai...
gpu/command_buffer/common/mailbox.cc:5: #include "../common/mailbox.h"
On 2013/03/04 18:27:41, Daniel Sievers wrote:
> here and below: 'gpu/command_buffer/' instead of '../'?

This is how it's done in gpu/ code, because of (IIRC) NaCl.

https://codereview.chromium.org/12378053/diff/1/gpu/ipc/gpu_command_buffer_tr...
File gpu/ipc/gpu_command_buffer_traits.cc (right):

https://codereview.chromium.org/12378053/diff/1/gpu/ipc/gpu_command_buffer_tr...
gpu/ipc/gpu_command_buffer_traits.cc:47: PickleIterator* iter,
On 2013/03/04 18:27:41, Daniel Sievers wrote:
> nit: alignment

Thanks, fixed.

[commit-bot: I haz the power, 2013-03-04 18:52:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/12378053/5003

[commit-bot: I haz the power, 2013-03-04 18:52:28]

Failed to apply patch for content/renderer/gpu/mailbox_output_surface.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/renderer/gpu/mailbox_output_surface.h
  Hunk #1 FAILED at 47.
  1 out of 1 hunk FAILED -- saving rejects to file
content/renderer/gpu/mailbox_output_surface.h.rej

Patch:       content/renderer/gpu/mailbox_output_surface.h
Index: content/renderer/gpu/mailbox_output_surface.h
diff --git a/content/renderer/gpu/mailbox_output_surface.h
b/content/renderer/gpu/mailbox_output_surface.h
index
617200d429473d2ea397a7738d8b4df1b0593452..046ea34f8d2d6dc6e087e0ff08554143d4c5b168
100644
--- a/content/renderer/gpu/mailbox_output_surface.h
+++ b/content/renderer/gpu/mailbox_output_surface.h
@@ -47,14 +47,14 @@ class MailboxOutputSurface : public CompositorOutputSurface
{
         : texture_id(0) {}
 
     TransferableFrame(uint32 texture_id,
-                      const cc::Mailbox& mailbox,
+                      const gpu::Mailbox& mailbox,
                       const gfx::Size& size)
         : texture_id(texture_id),
           mailbox(mailbox),
           size(size) {}
 
     uint32 texture_id;
-    cc::Mailbox mailbox;
+    gpu::Mailbox mailbox;
     gfx::Size size;
   };
   TransferableFrame current_backing_;

[commit-bot: I haz the power, 2013-03-04 18:54:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/12378053/6002

[commit-bot: I haz the power, 2013-03-04 19:13:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/12378053/12001

[commit-bot: I haz the power, 2013-03-04 19:42:15]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-03-04 19:47:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/12378053/14003

[commit-bot: I haz the power, 2013-03-04 20:01:41]

Failed to trigger a try job on win7_aura
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-03-04 20:01:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/12378053/9008

[commit-bot: I haz the power, 2013-03-04 22:46:10]

Change committed as 186006