Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1317)

Issue 12378050: PPAPI: Remove threading options; it's always on (Closed)

Created:
7 years, 9 months ago by dmichael (off chromium)
Modified:
7 years, 8 months ago
Reviewers:
teravest, brettw, raymes
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

PPAPI: Remove threading options; it's always on This also re-enables thread checking for the host side resource and var trackers. Before, checking was disabled everywhere. BUG=159240, 92909 Committed: r186925 Reverted: r186939 due to build errors Committed: r187340 Committed: r187427 Reverted: r187668 due to a failing check in Canary, which was fixed here: r187681 Committed: r189518 Reverted: r189682, due to regression in Kraken (see crbug.com/222741) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191420 Reverted: r191441, due to new failing PDFResource unit test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191510

Patch Set 1 : merge, use ThreadChecker instead of ThreadCheckerImpl #

Patch Set 2 : Add locking_resource_releaser.h to ppapi_proxy.gypi #

Patch Set 3 : Merge, remove one more ENABLE_PEPPER_THREADING #

Patch Set 4 : Don't use ThreadCheckerImpl directly(!!) #

Patch Set 5 : merge #

Patch Set 6 : Really use ThreadChecker, not ThreadCheckerImpl #

Patch Set 7 : merge #

Patch Set 8 : Only AssertAcquired in debug builds :'-( #

Patch Set 9 : Merge #

Patch Set 10 : Fix PDFResource unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -227 lines) Patch
M build/common.gypi View 1 2 3 4 5 6 7 8 3 chunks +0 lines, -9 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/ppapi_ipc_untrusted.gyp View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/ppapi_proxy_untrusted.gyp View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M ppapi/ppapi_shared_untrusted.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M ppapi/proxy/device_enumeration_resource_helper_unittest.cc View 10 chunks +60 lines, -37 lines 0 comments Download
M ppapi/proxy/file_chooser_resource_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/flash_resource_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A ppapi/proxy/locking_resource_releaser.h View 1 chunk +41 lines, -0 lines 0 comments Download
M ppapi/proxy/pdf_resource_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/plugin_globals.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ppapi/proxy/plugin_globals.cc View 2 chunks +18 lines, -24 lines 0 comments Download
M ppapi/proxy/plugin_resource_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_resource_tracker_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ppapi/proxy/plugin_var_tracker.cc View 1 2 3 4 5 6 7 chunks +7 lines, -9 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 3 chunks +12 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_var_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/proxy/ppp_instance_private_proxy_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ppapi/proxy/printing_resource_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ppapi/proxy/websocket_resource_unittest.cc View 6 chunks +15 lines, -14 lines 0 comments Download
M ppapi/shared_impl/resource_tracker.h View 1 2 3 5 4 chunks +16 lines, -14 lines 0 comments Download
M ppapi/shared_impl/resource_tracker.cc View 1 2 3 4 5 6 7 8 chunks +18 lines, -10 lines 0 comments Download
M ppapi/shared_impl/test_globals.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/test_globals.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/shared_impl/var_tracker.h View 1 2 3 4 5 6 4 chunks +19 lines, -10 lines 0 comments Download
M ppapi/shared_impl/var_tracker.cc View 1 2 3 4 5 6 7 13 chunks +24 lines, -28 lines 0 comments Download
M ppapi/tests/test_case.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webkit/plugins/plugin_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/plugin_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/host_globals.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/host_var_tracker.cc View 1 2 3 4 5 6 6 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
dmichael (off chromium)
7 years, 9 months ago (2013-03-05 22:26:34 UTC) #1
teravest
lgtm
7 years, 9 months ago (2013-03-06 18:55:53 UTC) #2
raymes
lgtm Looks good, thanks. I'm assuming you've grepped for ENABLE_PEPPER_THREADING and removed all the references. ...
7 years, 9 months ago (2013-03-07 18:09:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12378050/21001
7 years, 9 months ago (2013-03-07 21:53:35 UTC) #4
commit-bot: I haz the power
Presubmit check for 12378050-21001 failed and returned exit status 1. INFO:root:Found 34 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-07 21:53:49 UTC) #5
dmichael (off chromium)
+brettw for content and ppapi/plugins OWNERS review
7 years, 9 months ago (2013-03-07 21:58:56 UTC) #6
brettw
LGTM rubberstamp
7 years, 9 months ago (2013-03-07 22:59:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12378050/21001
7 years, 9 months ago (2013-03-07 23:11:49 UTC) #8
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=17590
7 years, 9 months ago (2013-03-08 05:12:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12378050/21001
7 years, 9 months ago (2013-03-08 07:18:39 UTC) #10
commit-bot: I haz the power
Change committed as 186925
7 years, 9 months ago (2013-03-08 09:29:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12378050/56001
7 years, 9 months ago (2013-03-08 19:17:42 UTC) #12
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-08 19:31:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12378050/35004
7 years, 9 months ago (2013-03-11 17:06:03 UTC) #14
commit-bot: I haz the power
Change committed as 187340
7 years, 9 months ago (2013-03-11 19:33:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12378050/76003
7 years, 9 months ago (2013-03-11 21:30:18 UTC) #16
commit-bot: I haz the power
Change committed as 187427
7 years, 9 months ago (2013-03-12 00:41:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12378050/92010
7 years, 9 months ago (2013-03-20 16:25:24 UTC) #18
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=125075
7 years, 9 months ago (2013-03-20 22:42:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12378050/92010
7 years, 9 months ago (2013-03-20 23:00:34 UTC) #20
commit-bot: I haz the power
Change committed as 189518
7 years, 9 months ago (2013-03-21 03:58:11 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12378050/114001
7 years, 8 months ago (2013-03-28 22:38:32 UTC) #22
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, installer_util_unittests, ...
7 years, 8 months ago (2013-03-29 02:58:10 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12378050/134001
7 years, 8 months ago (2013-03-29 15:20:02 UTC) #24
commit-bot: I haz the power
Change committed as 191420
7 years, 8 months ago (2013-03-29 19:18:50 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12378050/148001
7 years, 8 months ago (2013-03-29 21:26:57 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12378050/148001
7 years, 8 months ago (2013-03-30 16:54:41 UTC) #27
commit-bot: I haz the power
7 years, 8 months ago (2013-03-30 17:08:15 UTC) #28
Message was sent while issue was closed.
Change committed as 191510

Powered by Google App Engine
This is Rietveld 408576698