Issue 12377095: Add "clear" to about://instant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12377095: Add "clear" to about://instant. (Closed)

Created:
7 years, 9 months ago by samarth

Modified:
7 years, 9 months ago

Reviewers:
sreeram, Evan Stade

CC:
chromium-reviews, melevin, sreeram, gideonwald, dominich, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, Jered

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add "clear" to about://instant. Allow users to clear all the log messages in about://instant which makes debugging a lot easier. Remove the old "Reset" button since it becomes confusing which one does what (and that button isn't really that useful anyway). TESTED=navigate to about://instant, click "Clear" BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186270

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -18 lines)			Patch
M	chrome/browser/instant/instant_controller.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/instant/instant_controller.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/instant/instant.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/instant/instant.js	View	1 2	3 chunks	+9 lines, -17 lines	0 comments	Download
M	chrome/browser/ui/webui/instant_ui.cc	View	1	3 chunks	+18 lines, -0 lines	0 comments	Download