Register instantiated types instead of instantiated classes in the resolver.

Register instantiated types instead of instantiated classes in the resolver.

Committed: https://code.google.com/p/dart/source/detail?r=19479

[ngeoffray, 2013-03-05 10:14:10]

LGTM

https://codereview.chromium.org/12377081/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/enqueue.dart (right):

https://codereview.chromium.org/12377081/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/enqueue.dart:101: void
registerInstantiatedClass(ClassElement cls) {
Remove this method?

https://codereview.chromium.org/12377081/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart
(left):

https://codereview.chromium.org/12377081/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:66: //
TODO(karlklose): remove this temporary fix: we need to add the classes
Why is this related?

[karlklose, 2013-03-05 11:34:30]

Thanks, Nicolas!

https://codereview.chromium.org/12377081/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/enqueue.dart (right):

https://codereview.chromium.org/12377081/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/enqueue.dart:101: void
registerInstantiatedClass(ClassElement cls) {
It still serves as a convenient method to register the rawType of a class that
does not have type arguments.

https://codereview.chromium.org/12377081/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart
(left):

https://codereview.chromium.org/12377081/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:66: //
TODO(karlklose): remove this temporary fix: we need to add the classes
Before, if you used a string literal it would not be in instantiatedTypes.
However, String implements Comparable<String>, so we expect String to be in
allArguments to generate a holder object, so we added it.

With the change, instantiatedTypes contains String and we add all type arguments
to its subtypes to allArguments.

[karlklose, 2013-03-05 13:42:14]

Committed patchset #3 manually as r19479 (presubmit successful).