Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 12377052: Add the editor unit tests to the editor itself. The editor can now test itself (Closed)

Created:
7 years, 9 months ago by devoncarew
Modified:
7 years, 9 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add the editor unit tests to the editor itself. The editor can now test itself when started with the --test command-line flag. Update the _test plugins to have valid version ranges. Use the version of hamcrest that the junit plugin depends on. Add a new junit test runner in the buildbot_test plugin. This checks for a --test flag, runs all the tests in a job, prints the results to stdout, and exits the editor. Update the build and test scripts. Committed: https://code.google.com/p/dart/source/detail?r=19360

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+631 lines, -80 lines) Patch
M editor/tools/features/com.google.dart.tools.deploy.feature/feature.xml View 1 chunk +49 lines, -0 lines 0 comments Download
M editor/tools/features/com.google.dart.tools.deploy.feature_releng/build_rcp.xml View 1 chunk +0 lines, -1 line 0 comments Download
M editor/tools/features/com.google.dart.tools.eclipse.platform.feature/feature.xml View 1 chunk +21 lines, -0 lines 2 comments Download
M editor/tools/features/com.google.dart.tools.tests.feature_releng/buildTests.xml View 2 chunks +3 lines, -13 lines 0 comments Download
M editor/tools/plugins/com.google.dart.compiler.js_test/plugin.properties View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.eclipse.core/plugin.properties View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.eclipse.ui/plugin.properties View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine.services_test/META-INF/MANIFEST.MF View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/META-INF/MANIFEST.MF View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.thirdparty/plugin.properties View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.thirdparty_test/.classpath View 1 chunk +0 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.thirdparty_test/.project View 1 chunk +0 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.thirdparty_test/META-INF/MANIFEST.MF View 2 chunks +1 line, -23 lines 0 comments Download
M editor/tools/plugins/com.google.dart.thirdparty_test/build.properties View 1 chunk +0 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.thirdparty_test/plugin.properties View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/plugin.properties View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/META-INF/MANIFEST.MF View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/plugin.properties View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/DartCoreTest.java View 1 chunk +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.core/plugin.properties View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.core_test/META-INF/MANIFEST.MF View 1 chunk +3 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.core_test/plugin.properties View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.ui/plugin.properties View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.search/plugin.properties View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.tests.buildbot_test/META-INF/MANIFEST.MF View 2 chunks +4 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.tests.buildbot_test/build.properties View 1 chunk +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.tests.buildbot_test/plugin.properties View 1 chunk +1 line, -1 line 0 comments Download
A editor/tools/plugins/com.google.dart.tools.tests.buildbot_test/plugin.xml View 1 chunk +9 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.tests.buildbot_test/src/com/google/dart/tools/tests/buildbot/BuildbotEarlyStartup.java View 1 chunk +35 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.tests.buildbot_test/src/com/google/dart/tools/tests/buildbot/BuildbotPlugin.java View 1 chunk +73 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.tests.buildbot_test/src/com/google/dart/tools/tests/buildbot/BuildbotTestsJob.java View 1 1 chunk +199 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.tests.buildbot_test/src/com/google/dart/tools/tests/buildbot/runner/AbstractTestRunner.java View 1 chunk +199 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui.swtbot_test/META-INF/MANIFEST.MF View 2 chunks +3 lines, -2 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui.swtbot_test/plugin.properties View 1 chunk +7 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui.web/plugin.properties View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/META-INF/MANIFEST.MF View 1 chunk +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/plugin.properties View 1 chunk +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.update.core/plugin.properties View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
devoncarew
7 years, 9 months ago (2013-03-01 21:02:09 UTC) #1
danrubel
lgtm https://codereview.chromium.org/12377052/diff/2001/editor/tools/features/com.google.dart.tools.eclipse.platform.feature/feature.xml File editor/tools/features/com.google.dart.tools.eclipse.platform.feature/feature.xml (right): https://codereview.chromium.org/12377052/diff/2001/editor/tools/features/com.google.dart.tools.eclipse.platform.feature/feature.xml#newcode903 editor/tools/features/com.google.dart.tools.eclipse.platform.feature/feature.xml:903: id="org.eclipse.team.core" I don't believe that team is needed ...
7 years, 9 months ago (2013-03-01 21:58:15 UTC) #2
devoncarew
https://codereview.chromium.org/12377052/diff/2001/editor/tools/features/com.google.dart.tools.eclipse.platform.feature/feature.xml File editor/tools/features/com.google.dart.tools.eclipse.platform.feature/feature.xml (right): https://codereview.chromium.org/12377052/diff/2001/editor/tools/features/com.google.dart.tools.eclipse.platform.feature/feature.xml#newcode903 editor/tools/features/com.google.dart.tools.eclipse.platform.feature/feature.xml:903: id="org.eclipse.team.core" On 2013/03/01 21:58:15, danrubel wrote: > I don't ...
7 years, 9 months ago (2013-03-01 23:02:54 UTC) #3
devoncarew
7 years, 9 months ago (2013-03-03 17:54:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19360 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698