chrome/test/data/extensions/api_test/debugger/background.js - Issue 12377047: Add chrome.debugger.getTargets method to discover available debug targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/debugger/background.js

Issue 12377047: Add chrome.debugger.getTargets method to discover available debug targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@targets

Patch Set: Removed flaky tests Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/debugger.json ('k') | chrome/test/data/extensions/api_test/debugger_extension/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/debugger/background.js

diff --git a/chrome/test/data/extensions/api_test/debugger/background.js b/chrome/test/data/extensions/api_test/debugger/background.js

index d68ed6b02ea831aa9875cc418eda0f4bc38e94b0..7a160c8fa5f67a0b4c56f656511e56d9dce7fc8c 100644

--- a/chrome/test/data/extensions/api_test/debugger/background.js

+++ b/chrome/test/data/extensions/api_test/debugger/background.js

@@ -9,6 +9,9 @@ var tabId;

var debuggee;

var protocolVersion = "1.0";

+var SILENT_FLAG_REQUIRED = "Cannot attach to this target unless " +

+ "'silent-debugger-extension-api' flag is enabled.";

chrome.test.runTests([

function attachMalformedVersion() {

@@ -106,10 +109,10 @@ chrome.test.runTests([

fail("No tab with given id " + missingDebuggee.tabId + "."));

- function attachToExtensionWithNoSilentFlag() {

- debuggeeExtension = {extensionId: "foo"};

+ function attachToOwnBackgroundPageWithNoSilentFlag() {

+ var ownExtensionId = chrome.extension.getURL('').split('/')[2];

+ debuggeeExtension = {extensionId: ownExtensionId};

chrome.debugger.attach(debuggeeExtension, protocolVersion,

- fail("Cannot attach to an extension unless " +

- "'silent-debugger-extension-api' flag is enabled."));

+ fail(SILENT_FLAG_REQUIRED));

}

]);