Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 12377035: Remove GetOutputNames from x11_util (Closed)

Created:
7 years, 9 months ago by oshima
Modified:
7 years, 9 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Remove GetOutputNames from x11_util Move the logic to find internal display's id to chromeos specific display_change_observer_x11.cc BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185479

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -62 lines) Patch
M ash/display/display_change_observer_x11.cc View 3 chunks +37 lines, -15 lines 0 comments Download
M ash/display/display_manager.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M ui/base/x/x11_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/x/x11_util.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
7 years, 9 months ago (2013-03-01 02:08:51 UTC) #1
Daniel Erat
lgtm
7 years, 9 months ago (2013-03-01 02:50:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/12377035/8001
7 years, 9 months ago (2013-03-01 03:31:45 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-01 07:32:25 UTC) #4
Message was sent while issue was closed.
Change committed as 185479

Powered by Google App Engine
This is Rietveld 408576698