chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java - Issue 1237623013: Allow client app choose whether custom action button is tinted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

Issue 1237623013: Allow client app choose whether custom action button is tinted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

index b4afbe6bbc8ec63d05ab5e3ec5c063dc9970bde5..d1500bcdf19252cb253d4bf786d4241d7a50a5e5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

@@ -6,7 +6,6 @@ package org.chromium.chrome.browser.toolbar;

import android.annotation.SuppressLint;

import android.content.Context;

-import android.graphics.Bitmap;

import android.graphics.Canvas;

import android.graphics.Rect;

import android.graphics.drawable.Drawable;

@@ -393,7 +392,7 @@ abstract class ToolbarLayout extends FrameLayout implements Toolbar {

* @param buttonSource The {@link Bitmap} resource to use as the source for the button.

* @param listener The {@link OnClickListener} to use for clicks to the button.

- public void addCustomActionButton(Bitmap buttonSource, OnClickListener listener) { }

+ public void addCustomActionButton(Drawable drawable, OnClickListener listener) { }

/**

* Triggered when the content view for the specified tab has changed.