Re-home the global MessageCenter to support Ash+Win environments.

Re-home the global MessageCenter to support Ash+Win environments.

In the case where Ash is displayed on Windows, we want a single
message center data structure with multiple UI surfaces for
notifications.

g_browser_process now manages the lifetime of the global Message
Center object, since its lifetime is always longer than Ash::Shell.

This allows us to re-enable the browser tests for message center
on Ash+Win, and stops a crash bug.

BUG=178429
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186220

[dewittj, 2013-02-27 23:48:52]

Could you guys preliminary review this change? As discussed over email, I made
initialization and destruction static routines of the MessageCenter class, and
followed the pattern of SystemTrayDelegate.

[stevenjb, 2013-02-28 01:16:59]

I like this much better, thanks!
LGTM w/nit

https://codereview.chromium.org/12375004/diff/1/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/12375004/diff/1/ash/shell.cc#newcode853
ash/shell.cc:853: return message_center::MessageCenter::Get();
Can we just get rid of this? I think we only use it in a few places.

[cpu_(ooo_6.6-7.5), 2013-02-28 01:23:21]

I don't see anything wrong with the patch.

[cpu_(ooo_6.6-7.5), 2013-02-28 01:24:00]

btw, how do you manualy test this?

[Dmitry Titov, 2013-02-28 01:35:47]

lgtm!

Do you need to update test_browser_process.*?

[dewittj, 2013-02-28 01:40:49]

On 2013/02/28 01:24:00, cpu wrote:
> btw, how do you manualy test this?

On my Win7 box:
src> python build\gyp_chromium -G output_dir=out_aura -D use_aura=1
src> ninja -C out_aura\Debug chrome
src> out_aura\Debug\chrome --enable-rich-notifications

Then:
* Click "Open Ash Desktop"
Open up "Notifications Galore":
https://chrome.google.com/webstore/a/google.com/detail/notifications-galore/j...
Then show notifications, click on them, close them, etc.

[dewittj, 2013-02-28 23:51:15]

sky, PTAL.  OWNERS for ash/ and chrome/browser/  thanks

[sky, 2013-03-01 00:37:01]

LGTM

[commit-bot: I haz the power, 2013-03-01 00:39:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dewittj@chromium.org/12375004/10001

[commit-bot: I haz the power, 2013-03-01 03:18:26]

Retried try job too often on win7_aura for step(s) ash_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[cpu_(ooo_6.6-7.5), 2013-03-01 04:10:54]

retrying CQ in lieu of dewitt, but low hopes.

[commit-bot: I haz the power, 2013-03-01 04:11:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dewittj@chromium.org/12375004/10001

[commit-bot: I haz the power, 2013-03-01 06:26:03]

Retried try job too often on win7_aura for step(s) ash_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-03-05 17:39:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dewittj@chromium.org/12375004/17005

[commit-bot: I haz the power, 2013-03-05 19:10:25]

Change committed as 186220

[flackr, 2013-03-05 22:57:43]

This seems to have broken ash_shell.

[stevenjb (google-dont-use), 2013-03-05 23:10:58]

We probably need to add message_center::MessageCenter::Initialize() (and
Shutdown) to ash_shell (possibly inside #if defined(ENABLE_MESSAGE_CENTER))




On Tue, Mar 5, 2013 at 2:57 PM, <flackr@chromium.org> wrote:

> This seems to have broken ash_shell.
>
>
https://chromiumcodereview.**appspot.com/12375004/<https://chromiumcodereview...
>

[dewittj, 2013-03-05 23:11:39]

On 2013/03/05 23:10:58, stevenjb1 wrote:
> We probably need to add message_center::MessageCenter::Initialize() (and
> Shutdown) to ash_shell (possibly inside #if defined(ENABLE_MESSAGE_CENTER))
> 
> 
> 
> 
> On Tue, Mar 5, 2013 at 2:57 PM, <mailto:flackr@chromium.org> wrote:
> 
> > This seems to have broken ash_shell.
> >
> >
>
https://chromiumcodereview.**appspot.com/12375004/%3Chttps://chromiumcoderevi...>
> >

I'm working on a change.

[dewittj, 2013-03-05 23:15:01]

On 2013/03/05 23:11:39, dewittj wrote:
> On 2013/03/05 23:10:58, stevenjb1 wrote:
> > We probably need to add message_center::MessageCenter::Initialize() (and
> > Shutdown) to ash_shell (possibly inside #if defined(ENABLE_MESSAGE_CENTER))
> > 
> > 
> > 
> > 
> > On Tue, Mar 5, 2013 at 2:57 PM, <mailto:flackr@chromium.org> wrote:
> > 
> > > This seems to have broken ash_shell.
> > >
> > >
> >
>
https://chromiumcodereview.**appspot.com/12375004/%253Chttps://chromiumcodere...>
> > >
> 
> I'm working on a change.

See crrev.com/12488003