Issue 12374085: Split stream_state_test into three files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12374085: Split stream_state_test into three files. (Closed)

Created:
7 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Split stream_state_test into three files. The test "framework" is in a file of its own, and the tests are split into those that uses timers greater than zero (which doesn't work on d8) and the rest. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19381

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -566 lines)			Patch
A +	tests/lib/async/stream_state_helper.dart	View	1 chunk	+2 lines, -219 lines	0 comments	Download
A	tests/lib/async/stream_state_nonzero_timer_test.dart	View	1 chunk	+83 lines, -0 lines	0 comments	Download
M	tests/lib/async/stream_state_test.dart	View	4 chunks	+2 lines, -347 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Committed patchset #1 manually as r19381 (presubmit successful).

7 years, 9 months ago (2013-03-04 13:23:52 UTC) #2

Message was sent while issue was closed.

LGTM!

Expand Messages | Collapse Messages