Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 12374042: Mac: Audio indicator in each tab (Closed)

Created:
7 years, 9 months ago by sail
Modified:
7 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

Mac: Audio indicator in each tab This is the Mac version of this views CL: https://chromiumcodereview.appspot.com/12328027/ When audio is playing a throbber animation is displayed in the tab. BUG=3541 TEST= Navigate to http://www.html5rocks.com/en/tutorials/video/basics/ Play video. Verify that throbber is displayed over the fav icon. Pause video. Verify that throbber stops. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185715

Patch Set 1 #

Patch Set 2 : " #

Total comments: 2

Patch Set 3 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/throbbing_image_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/throbbing_image_view.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sail
7 years, 9 months ago (2013-03-01 04:57:02 UTC) #1
Nico
lgtm That was easy :-) https://codereview.chromium.org/12374042/diff/2001/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right): https://codereview.chromium.org/12374042/diff/2001/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm#newcode1615 chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1615: ThrobbingImageView* recordingView = [[[ThrobbingImageView ...
7 years, 9 months ago (2013-03-01 09:55:22 UTC) #2
sail
https://codereview.chromium.org/12374042/diff/2001/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right): https://codereview.chromium.org/12374042/diff/2001/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm#newcode1615 chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1615: ThrobbingImageView* recordingView = [[[ThrobbingImageView alloc] On 2013/03/01 09:55:22, Nico ...
7 years, 9 months ago (2013-03-01 17:06:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12374042/7001
7 years, 9 months ago (2013-03-01 17:08:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/12374042/7001
7 years, 9 months ago (2013-03-02 16:13:22 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-02 17:14:35 UTC) #6
Message was sent while issue was closed.
Change committed as 185715

Powered by Google App Engine
This is Rietveld 408576698