Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12374036: Generate Java template enums into correct Java package hierarchy (Closed)

Created:
7 years, 9 months ago by newt (away)
Modified:
7 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Generate Java template enums into correct Java package hierarchy The moves NetError.java (generated from NetError.template) from out/Debug/gen/templates/org.chromium.net/NetError.java to out/Debug/gen/templates/org/chromium/net/NetError.java This is intended to help IDEs find the generated files. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M build/android/java_cpp_template.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content.gyp View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
newt (away)
+cjhopman, who knows about java_cpp_template.gypi +creis for content.gyp +eroman for net.gyp
7 years, 9 months ago (2013-02-28 23:58:56 UTC) #1
cjhopman
lgtm. Might want to try a clean build for this.
7 years, 9 months ago (2013-03-01 00:03:32 UTC) #2
Charlie Reis
Rubber stamp LGTM on content/, since I don't really understand the implications of the change.
7 years, 9 months ago (2013-03-01 00:13:04 UTC) #3
newt (away)
verified that it works on a clean build
7 years, 9 months ago (2013-03-01 00:24:54 UTC) #4
newt (away)
+eroman for net.gyp for real this time
7 years, 9 months ago (2013-03-01 00:25:16 UTC) #5
eroman
rubber stamp for net.gyp
7 years, 9 months ago (2013-03-01 07:08:57 UTC) #6
eroman
LGTM
7 years, 9 months ago (2013-03-01 07:09:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/12374036/1
7 years, 9 months ago (2013-03-01 16:41:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/12374036/1
7 years, 9 months ago (2013-03-02 16:12:10 UTC) #9
commit-bot: I haz the power
7 years, 9 months ago (2013-03-02 16:39:09 UTC) #10
Message was sent while issue was closed. 
Change committed as 185702

Powered by Google App Engine
This is Rietveld 408576698