Issue 12374019: Changing color for text in login screen action area.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12374019: Changing color for text in login screen action area. (Closed)

Created:
7 years, 9 months ago by glotov

Modified:
7 years, 9 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Changing color for text in login screen action area. BUG=177523 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185347

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/chromeos/login/user_pod_row.css	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

Nikita (slow)

lgtm Feedback also had a suggestion to use ellipsis (...) for text overflow. If email ...

7 years, 9 months ago (2013-02-28 16:08:07 UTC) #2

glotov

Ah, yes, almost forgot. Wanted to ask, what does it mean "really long"? We must ...

7 years, 9 months ago (2013-02-28 19:52:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/12374019/1

7 years, 9 months ago (2013-02-28 19:54:01 UTC) #4

Nikita (slow)

Just use text-overflow: ellipsis. Long - that means if text doesn't fit div width. On ...

7 years, 9 months ago (2013-02-28 21:06:40 UTC) #5

Message was sent while issue was closed.

Change committed as 185347