Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chrome/browser/signin/signin_browsertest.cc

Issue 12374007: signin: force web signin flow initiated visits to accounts.google.com to their own process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/signin/signin_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_browsertest.cc
diff --git a/chrome/browser/signin/signin_browsertest.cc b/chrome/browser/signin/signin_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e3666ce7897b31e79dabe35c159221a4ad5cb86b
--- /dev/null
+++ b/chrome/browser/signin/signin_browsertest.cc
@@ -0,0 +1,107 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SIGNIN_SIGNIN_BROWSERTEST_H_
+#define CHROME_BROWSER_SIGNIN_SIGNIN_BROWSERTEST_H_
+
+#include "chrome/browser/signin/signin_manager.h"
+#include "chrome/browser/signin/signin_manager_factory.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/webui/signin/login_ui_service.h"
+#include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
+#include "chrome/browser/ui/webui/sync_promo/sync_promo_ui.h"
+#include "chrome/common/url_constants.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/web_contents.h"
+#include "google_apis/gaia/gaia_urls.h"
+#include "net/url_request/test_url_fetcher_factory.h"
+
+namespace {
+ const char kNonSigninURL[] = "www.google.com";
+}
+
+class SigninBrowserTest : public InProcessBrowserTest {
+ public:
+ virtual void SetUp() OVERRIDE {
+ factory_.reset(new net::URLFetcherImplFactory());
+ fake_factory_.reset(new net::FakeURLFetcherFactory(factory_.get()));
+ fake_factory_->SetFakeResponse(
+ GaiaUrls::GetInstance()->service_login_url(),
+ std::string(),
+ true);
+ fake_factory_->SetFakeResponse(kNonSigninURL, std::string(), true);
+ // Yield control back to the InProcessBrowserTest framework.
+ InProcessBrowserTest::SetUp();
+ }
+
+ virtual void TearDown() OVERRIDE {
+ if (fake_factory_.get()) {
+ fake_factory_->ClearFakeResponses();
+ fake_factory_.reset();
+ }
+
+ // Cancel any outstanding URL fetches and destroy the URLFetcherImplFactory
+ // we created.
+ net::URLFetcher::CancelAll();
+ factory_.reset();
+ InProcessBrowserTest::TearDown();
+ }
+
+ private:
+ // Fake URLFetcher factory used to mock out GAIA signin.
+ scoped_ptr<net::FakeURLFetcherFactory> fake_factory_;
+
+ // The URLFetcherImplFactory instance used to instantiate |fake_factory_|.
+ scoped_ptr<net::URLFetcherImplFactory> factory_;
+};
+
+IN_PROC_BROWSER_TEST_F(SigninBrowserTest, ProcessIsolation) {
+ // If the one-click-signin feature is not enabled (e.g Chrome OS), we
+ // never grant signin privileges to any renderer processes.
+ const bool kOneClickSigninEnabled = SyncPromoUI::UseWebBasedSigninFlow();
+
+ SigninManager* signin = SigninManagerFactory::GetForProfile(
+ browser()->profile());
+ EXPECT_FALSE(signin->HasSigninProcess());
+
+ ui_test_utils::NavigateToURL(browser(), SyncPromoUI::GetSyncPromoURL(
+ GURL(), SyncPromoUI::SOURCE_NTP_LINK, true));
+ EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess());
+
+ // Navigating away should change the process.
+ ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUINewTabURL));
+ EXPECT_FALSE(signin->HasSigninProcess());
+
+ ui_test_utils::NavigateToURL(browser(), SyncPromoUI::GetSyncPromoURL(
+ GURL(), SyncPromoUI::SOURCE_NTP_LINK, true));
+ EXPECT_EQ(kOneClickSigninEnabled, signin->HasSigninProcess());
+
+ content::WebContents* active_tab =
+ browser()->tab_strip_model()->GetActiveWebContents();
+ int active_tab_process_id =
+ active_tab->GetRenderProcessHost()->GetID();
+ EXPECT_EQ(kOneClickSigninEnabled,
+ signin->IsSigninProcess(active_tab_process_id));
+ EXPECT_EQ(0, active_tab->GetRenderViewHost()->GetEnabledBindings());
+
+ // Entry points to signin request "SINGLETON_TAB" mode, so a new request
+ // shouldn't change anything.
+ LoginUIService* login = LoginUIServiceFactory::GetForProfile(
+ browser()->profile());
+ login->ShowLoginPopup();
+ EXPECT_EQ(active_tab, browser()->tab_strip_model()->GetActiveWebContents());
+ EXPECT_EQ(kOneClickSigninEnabled,
+ signin->IsSigninProcess(active_tab_process_id));
+
+ // Navigating away should change the process.
+ ui_test_utils::NavigateToURL(browser(), GURL(kNonSigninURL));
+ EXPECT_FALSE(signin->IsSigninProcess(
+ active_tab->GetRenderProcessHost()->GetID()));
+}
+
+#endif // CHROME_BROWSER_SIGNIN_SIGNIN_BROWSERTEST_H_
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/signin/signin_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698