Issue 12374003: Fix crash in chrome when trying to print with CUPS down

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12374003: Fix crash in chrome when trying to print with CUPS down (Closed)

Created:
7 years, 9 months ago by Noam Samuel (WRONG ACCOUNT)

Modified:
7 years, 9 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix crash in chrome when trying to print with CUPS down This is a workaround for GTK bug https://bugzilla.gnome.org/show_bug.cgi?id=686838. Removed listing of printers when setting up default settings in native print dialog, as it is not necessary (behavior verified to be unchanged). Added check to ensure print preview dialog does not try to instantiate a printer list when selecting a cloud printer, as this is also unnecessary (again, no behavior change). BUG=160574 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185284

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -13 lines)			Patch
	M	chrome/browser/printing/print_dialog_gtk.cc	View	1	2 chunks	+5 lines, -13 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@google.com/12374003/3001

7 years, 9 months ago (2013-02-28 00:13:15 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=116476

7 years, 9 months ago (2013-02-28 02:22:00 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@google.com/12374003/3001

7 years, 9 months ago (2013-02-28 18:02:22 UTC) #5

Message was sent while issue was closed.

Change committed as 185284

Expand Messages | Collapse Messages