chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc - Issue 1237343002: Fix nested GuestView's container bounds calculation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

Issue 1237343002: Fix nested GuestView's container bounds calculation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix type mismatch for win_x64 compile Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

diff --git a/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc b/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

index 06f2b29655a8887c41dcf7df9ae78bf07fa54883..734fb35696bb1c78349c824d3ebf3409b4f1ed35 100644

--- a/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

+++ b/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

@@ -823,7 +823,7 @@ IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest,

TestHelper("testNewWindowOpenerDestroyedWhileUnattached",

"web_view/newwindow",

NEEDS_TEST_SERVER);

- ASSERT_EQ(2, GetGuestViewManager()->num_guests_created());

+ ASSERT_EQ(2u, GetGuestViewManager()->num_guests_created());

// We have two guests in this test, one is the intial one, the other

// is the newwindow one.

« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | chrome/browser/pdf/pdf_extension_test.cc » ('j') | no next file with comments »