Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1620)

Unified Diff: cc/trees/layer_tree_host_impl_unittest.cc

Issue 1236643003: [Android] Suppress overscroll for unscrollable axes in the browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove old test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/viewport.cc ('k') | cc/trees/layer_tree_settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl_unittest.cc
diff --git a/cc/trees/layer_tree_host_impl_unittest.cc b/cc/trees/layer_tree_host_impl_unittest.cc
index df0a5692a6a81408b26c396818702fb2ec5e7deb..e78b1c7a4172713d5207df13f4cacc1381405822 100644
--- a/cc/trees/layer_tree_host_impl_unittest.cc
+++ b/cc/trees/layer_tree_host_impl_unittest.cc
@@ -101,7 +101,6 @@ class LayerTreeHostImplTest : public testing::Test,
LayerTreeSettings settings;
settings.minimum_occlusion_tracking_size = gfx::Size();
settings.renderer_settings.texture_id_allocation_chunk_size = 1;
- settings.report_overscroll_only_for_scrollable_axes = true;
settings.gpu_rasterization_enabled = true;
return settings;
}
@@ -4636,51 +4635,6 @@ TEST_F(LayerTreeHostImplTest, OverscrollAlways) {
EXPECT_EQ(gfx::Vector2dF(0, 10), host_impl_->accumulated_root_overscroll());
}
-TEST_F(LayerTreeHostImplTest, NoOverscrollOnFractionalDeviceScale) {
- InputHandlerScrollResult scroll_result;
- gfx::Size surface_size(980, 1439);
- gfx::Size content_size(980, 1438);
- float device_scale_factor = 1.5f;
- scoped_ptr<LayerImpl> root_clip =
- LayerImpl::Create(host_impl_->active_tree(), 3);
- root_clip->SetHasRenderSurface(true);
-
- scoped_ptr<LayerImpl> root =
- CreateScrollableLayer(1, content_size, root_clip.get());
- root->SetIsContainerForFixedPositionLayers(true);
- scoped_ptr<LayerImpl> child =
- CreateScrollableLayer(2, content_size, root_clip.get());
- root->scroll_clip_layer()->SetBounds(gfx::Size(320, 469));
- host_impl_->active_tree()->PushPageScaleFromMainThread(0.326531f, 0.326531f,
- 5.f);
- host_impl_->SetPageScaleOnActiveTree(0.326531f);
- child->SetScrollClipLayer(Layer::INVALID_ID);
- root->AddChild(child.Pass());
- root_clip->AddChild(root.Pass());
-
- host_impl_->SetViewportSize(surface_size);
- host_impl_->SetDeviceScaleFactor(device_scale_factor);
- host_impl_->active_tree()->SetRootLayer(root_clip.Pass());
- host_impl_->active_tree()->SetViewportLayersFromIds(Layer::INVALID_ID, 3, 1,
- Layer::INVALID_ID);
- host_impl_->active_tree()->DidBecomeActive();
- DrawFrame();
- {
- // Horizontal & Vertical GlowEffect should not be applied when
- // content size is less then view port size. For Example Horizontal &
- // vertical GlowEffect should not be applied in about:blank page.
- EXPECT_EQ(InputHandler::SCROLL_STARTED,
- host_impl_->ScrollBegin(gfx::Point(0, 0), InputHandler::WHEEL));
- scroll_result = host_impl_->ScrollBy(gfx::Point(), gfx::Vector2dF(0, -1));
- EXPECT_FALSE(scroll_result.did_scroll);
- EXPECT_FALSE(scroll_result.did_overscroll_root);
- EXPECT_EQ(gfx::Vector2dF().ToString(),
- host_impl_->accumulated_root_overscroll().ToString());
-
- host_impl_->ScrollEnd();
- }
-}
-
TEST_F(LayerTreeHostImplTest, NoOverscrollWhenNotAtEdge) {
InputHandlerScrollResult scroll_result;
gfx::Size surface_size(100, 100);
« no previous file with comments | « cc/layers/viewport.cc ('k') | cc/trees/layer_tree_settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698