base/sys_info.h - Issue 1234543003: Report Android Build.MODEL in SystemProfileProto hardware_class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/sys_info.h

Issue 1234543003: Report Android Build.MODEL in SystemProfileProto hardware_class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typo, use GetDeviceName(). Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/sys_info.h

diff --git a/base/sys_info.h b/base/sys_info.h

index 654d6945a34ba26250356f5b21caa5c8a16f6112..1d2d4bf6586dcab0fff6033200b9a2319e0d69a7 100644

--- a/base/sys_info.h

+++ b/base/sys_info.h

@@ -52,9 +52,10 @@ class BASE_EXPORT SysInfo {

static int64 Uptime();

// Returns a descriptive string for the current machine model or an empty

- // string if machime model is unknown or an error occured.

+ // string if the machine model is unknown or an error occured.

// e.g. MacPro1,1 on Mac.

jdduke (slow) 2015/07/14 15:04:31 another example for Android might be nice.

tdresser 2015/07/14 18:42:40 Done.

- // Only implemented on OS X, will return an empty string on other platforms.

+ // Only implemented on OS X and Android, will return an empty string on other

+ // platforms.

static std::string HardwareModelName();

// Returns the name of the host operating system.

« no previous file with comments | « no previous file | base/sys_info.cc » ('j') | no next file with comments »