Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: components/metrics/proto/system_profile.proto

Issue 1234543003: Report Android Build.MODEL in SystemProfileProto hardware_class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address rkaplow's comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/android/android_about_app_info.cc ('k') | content/common/user_agent.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Stores information about the user's brower and system configuration. 5 // Stores information about the user's brower and system configuration.
6 // The system configuration fields are recorded once per client session. 6 // The system configuration fields are recorded once per client session.
7 7
8 syntax = "proto2"; 8 syntax = "proto2";
9 9
10 option optimize_for = LITE_RUNTIME; 10 option optimize_for = LITE_RUNTIME;
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 // The CPU architecture (x86, PowerPC, x86_64, ...) 105 // The CPU architecture (x86, PowerPC, x86_64, ...)
106 optional string cpu_architecture = 1; 106 optional string cpu_architecture = 1;
107 107
108 // The amount of RAM present on the system, in megabytes. 108 // The amount of RAM present on the system, in megabytes.
109 optional int64 system_ram_mb = 2; 109 optional int64 system_ram_mb = 2;
110 110
111 // The base memory address that chrome.dll was loaded at. 111 // The base memory address that chrome.dll was loaded at.
112 // (Logged only on Windows.) 112 // (Logged only on Windows.)
113 optional int64 dll_base = 3; 113 optional int64 dll_base = 3;
114 114
115 // The Chrome OS device hardware class ID is a unique string associated with 115 // The hardware_class describes the current machine model, e.g. "MacPro1,1"
Alexei Svitkine (slow) 2015/07/21 16:52:11 Can you also send a CL to update this comment in t
116 // each Chrome OS device product revision generally assigned at hardware 116 // on Mac, or "Nexus 5" on Android. Only implemented on OS X, Android, and
117 // qualification time. The hardware class effectively identifies the 117 // Chrome OS.
118 // configured system components such as CPU, WiFi adapter, etc. 118 //
119 // For Chrome OS, the device hardware class ID is a unique string associated
120 // with each Chrome OS device product revision generally assigned at
121 // hardware qualification time. The hardware class effectively identifies
122 // the configured system components such as CPU, WiFi adapter, etc.
119 // 123 //
120 // An example of such a hardware class is "IEC MARIO PONY 6101". An 124 // An example of such a hardware class is "IEC MARIO PONY 6101". An
121 // internal database associates this hardware class with the qualified 125 // internal database associates this hardware class with the qualified
122 // device specifications including OEM information, schematics, hardware 126 // device specifications including OEM information, schematics, hardware
123 // qualification reports, test device tags, etc. 127 // qualification reports, test device tags, etc.
124 optional string hardware_class = 4; 128 optional string hardware_class = 4;
125 129
126 // The number of physical screens. 130 // The number of physical screens.
127 optional int32 screen_count = 5; 131 optional int32 screen_count = 5;
128 132
(...skipping 604 matching lines...) Expand 10 before | Expand all | Expand 10 after
733 // then HAS_OFFSTORE is reported. This should be kept in sync with the 737 // then HAS_OFFSTORE is reported. This should be kept in sync with the
734 // corresponding enum in chrome/browser/metrics/extensions_metrics_provider.cc 738 // corresponding enum in chrome/browser/metrics/extensions_metrics_provider.cc
735 enum ExtensionsState { 739 enum ExtensionsState {
736 NO_EXTENSIONS = 0; 740 NO_EXTENSIONS = 0;
737 NO_OFFSTORE_VERIFIED = 1; 741 NO_OFFSTORE_VERIFIED = 1;
738 NO_OFFSTORE_UNVERIFIED = 2; 742 NO_OFFSTORE_UNVERIFIED = 2;
739 HAS_OFFSTORE = 3; 743 HAS_OFFSTORE = 3;
740 } 744 }
741 optional ExtensionsState offstore_extensions_state = 19; 745 optional ExtensionsState offstore_extensions_state = 19;
742 } 746 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/android/android_about_app_info.cc ('k') | content/common/user_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698