Issue 12342026: Fix GetDialogButtonLabel for UninstallView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12342026: Fix GetDialogButtonLabel for UninstallView. (Closed)

Created:
7 years, 10 months ago by msw

Modified:
7 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix GetDialogButtonLabel for UninstallView. Return the base class text for the cancel button. This was a regression from http://crrev.com/183286. That changed the behavior of GetDialogButtonLabel. I simply missed this dialog in the update; sorry! BUG=166075, 178464 TEST=Uninstall dialog has expected Cancel button text. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184851

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	chrome/browser/ui/views/uninstall_view.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12342026/1

7 years, 10 months ago (2013-02-27 00:14:37 UTC) #3

Message was sent while issue was closed.

Change committed as 184851