Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 12340089: Windows: Only collect D3D11 UMA stats if the GPU process launches and initializes successfully. (Closed)

Created:
7 years, 10 months ago by apatrick_chromium
Modified:
7 years, 9 months ago
Reviewers:
Vangelis Kokkevis
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Windows: Only collect D3D11 UMA stats if the GPU process launches and initializes successfully. DisplayLink seems to make D3D initialization crash. It turns out we have the same issue with D3D9 as well. However, in the case of D3D9, the GPU process tends to crash first, causing the browser process to not use D3D for anything. By waiting to see whether the GPU process crashes, the browser process should not crash (often) if a problematic version of DisplayLink is installed. BUG=175525 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186559

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -35 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 2 3 3 chunks +13 lines, -0 lines 0 comments Download
M content/gpu/gpu_info_collector.h View 1 2 3 2 chunks +14 lines, -8 lines 0 comments Download
M content/gpu/gpu_info_collector_win.cc View 1 2 3 3 chunks +14 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
apatrick_chromium
7 years, 10 months ago (2013-02-26 23:07:30 UTC) #1
Vangelis Kokkevis
lgtm
7 years, 10 months ago (2013-02-27 00:15:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/12340089/29001
7 years, 9 months ago (2013-03-06 20:46:09 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-07 01:03:51 UTC) #4
Message was sent while issue was closed.
Change committed as 186559

Powered by Google App Engine
This is Rietveld 408576698