editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameUnitMemberRefactoringImpl.java - Issue 12340077: Initial binding of RenameRefactoring service to Eclipse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameUnitMemberRefactoringImpl.java

Issue 12340077: Initial binding of RenameRefactoring service to Eclipse. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameRefactoringImpl.java ('k') | editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/refactoring/RenameRefactoring.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameUnitMemberRefactoringImpl.java

diff --git a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameUnitMemberRefactoringImpl.java b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameUnitMemberRefactoringImpl.java

index 2f96522a50835c1d05bee912986b719b170d1ef8..8af148d67afa37d30957b0ab5d25e7b6445a481c 100644

--- a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameUnitMemberRefactoringImpl.java

+++ b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/refactoring/RenameUnitMemberRefactoringImpl.java

@@ -66,9 +66,9 @@ public class RenameUnitMemberRefactoringImpl extends RenameRefactoringImpl {

}

@Override

- public RefactoringStatus checkInitialConditions(ProgressMonitor pm) throws Exception {

+ public RefactoringStatus checkNewName(String newName) {

RefactoringStatus result = new RefactoringStatus();

- result.merge(super.checkInitialConditions(pm));

+ result.merge(super.checkNewName(newName));

if (element instanceof TopLevelVariableElement) {

result.merge(NamingConventions.validateVariableName(newName));

}