Issue 12340076: cc: Only create compositor context once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12340076: cc: Only create compositor context once. (Closed)

Created:
7 years, 10 months ago by danakj

Modified:
7 years, 10 months ago

Reviewers:
jamesr, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Only create compositor thread context once. The RenderWidgetCompositor asks the SharedContext3D to create its compositor thread context every frame. This causes us to destroy the old (valid) context, which tears down the CommandBufferProxyImpl on the main thread causing an assertion. We should only create a new context the first time we create the ContextProvider, ie only on first use and after a context loss. This change keeps the existing code from asserting, though the code will be replaced entirely soon by moving context ownership and the ContextProvider to RenderThreadImpl. R=jamesr,piman BUG=177768 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184736

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	content/renderer/gpu/render_widget_compositor.cc	View		2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12340076/1

7 years, 10 months ago (2013-02-26 17:52:36 UTC) #3

Message was sent while issue was closed.

Change committed as 184736

Expand Messages | Collapse Messages