chrome/browser/password_manager/password_manager_delegate_impl.cc - Issue 12340065: Move the UI related code from AutofillExternalDelegate to AutofillManagerDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager_delegate_impl.cc

Issue 12340065: Move the UI related code from AutofillExternalDelegate to AutofillManagerDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Try to fix AutofillTest.DisableAutocompleteWhileFilling Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/test_autofill_manager_delegate.cc ('k') | chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_manager_delegate_impl.cc

diff --git a/chrome/browser/password_manager/password_manager_delegate_impl.cc b/chrome/browser/password_manager/password_manager_delegate_impl.cc

index fc9c55eb740cdde6ffe83ba0c3686689deb52257..52b0819437d4c707fa0f5065f87bfe945346d522 100644

--- a/chrome/browser/password_manager/password_manager_delegate_impl.cc

+++ b/chrome/browser/password_manager/password_manager_delegate_impl.cc

@@ -166,7 +166,8 @@ void PasswordManagerDelegateImpl::FillPasswordForm(

const PasswordFormFillData& form_data) {

AutofillManager* autofill_manager =

AutofillManager::FromWebContents(web_contents_);

- bool disable_popup = autofill_manager->HasExternalDelegate();

+ // Browser process will own popup UI, so renderer should not show the popup.

+ bool disable_popup = autofill_manager->IsNativeUiEnabled();

web_contents_->GetRenderViewHost()->Send(

new AutofillMsg_FillPasswordForm(