Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: chrome/browser/autofill/autofill_manager.cc

Issue 12340065: Move the UI related code from AutofillExternalDelegate to AutofillManagerDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Try to fix AutofillTest.DisableAutocompleteWhileFilling Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_manager.h ('k') | chrome/browser/autofill/autofill_manager_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_manager.cc
diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc
index ae55f144c61661db7a0a5da33d313bafc681ebe8..eedeb9c4669b887955b00f59f90f27e90a04f9fe 100644
--- a/chrome/browser/autofill/autofill_manager.cc
+++ b/chrome/browser/autofill/autofill_manager.cc
@@ -323,7 +323,7 @@ void AutofillManager::SetExternalDelegate(AutofillExternalDelegate* delegate) {
autocomplete_history_manager_.SetExternalDelegate(delegate);
}
-bool AutofillManager::HasExternalDelegate() {
+bool AutofillManager::IsNativeUiEnabled() {
return external_delegate_ != NULL;
}
@@ -729,8 +729,8 @@ void AutofillManager::OnDidShowAutofillSuggestions(bool is_new_popup) {
}
void AutofillManager::OnHideAutofillPopup() {
- if (external_delegate_)
- external_delegate_->HideAutofillPopup();
+ if (IsNativeUiEnabled())
+ manager_delegate_->HideAutofillPopup();
}
void AutofillManager::OnShowPasswordGenerationPopup(
« no previous file with comments | « chrome/browser/autofill/autofill_manager.h ('k') | chrome/browser/autofill/autofill_manager_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698