chrome/browser/autofill/autofill_browsertest.cc - Issue 12340065: Move the UI related code from AutofillExternalDelegate to AutofillManagerDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_browsertest.cc

Issue 12340065: Move the UI related code from AutofillExternalDelegate to AutofillManagerDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Try to fix AutofillTest.DisableAutocompleteWhileFilling Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/autocomplete_history_manager_unittest.cc ('k') | chrome/browser/autofill/autofill_external_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/autofill_browsertest.cc

diff --git a/chrome/browser/autofill/autofill_browsertest.cc b/chrome/browser/autofill/autofill_browsertest.cc

index 4c56770a5b10dd1692f9f1ad436a9269fcf18bb7..522c35e9d68ce85fc226bf57c9ce10c93a556f21 100644

--- a/chrome/browser/autofill/autofill_browsertest.cc

+++ b/chrome/browser/autofill/autofill_browsertest.cc

@@ -203,15 +203,6 @@ class AutofillTest : public InProcessBrowserTest {

autofill_manager->SetExternalDelegate(external_delegate_.get());

}

- virtual void CleanUpOnMainThread() OVERRIDE {

- // Tear down the test external delegate while the UI is still up, as it

- // might try to close the active popup if there still is one.

- content::WebContents* web_contents =

- browser()->tab_strip_model()->GetActiveWebContents();

- AutofillManager::FromWebContents(web_contents)->SetExternalDelegate(NULL);

- external_delegate_.reset();

- }

PersonalDataManager* personal_data_manager() {

return PersonalDataManagerFactory::GetForProfile(browser()->profile());

}