Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: chrome/browser/autofill/autofill_manager.h

Issue 12340065: Move the UI related code from AutofillExternalDelegate to AutofillManagerDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Try to fix AutofillTest.DisableAutocompleteWhileFilling Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_ 5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_
6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_ 6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 content::WebContents* contents, 82 content::WebContents* contents,
83 autofill::AutofillManagerDelegate* delegate); 83 autofill::AutofillManagerDelegate* delegate);
84 static AutofillManager* FromWebContents(content::WebContents* contents); 84 static AutofillManager* FromWebContents(content::WebContents* contents);
85 85
86 // Registers our Enable/Disable Autofill pref. 86 // Registers our Enable/Disable Autofill pref.
87 static void RegisterUserPrefs(PrefRegistrySyncable* registry); 87 static void RegisterUserPrefs(PrefRegistrySyncable* registry);
88 88
89 // Set an external delegate. 89 // Set an external delegate.
90 void SetExternalDelegate(AutofillExternalDelegate* delegate); 90 void SetExternalDelegate(AutofillExternalDelegate* delegate);
91 91
92 // Used to say if this class has an external delegate that it is using. 92 // Whether browser process will create and own the Autofill popup UI.
93 bool HasExternalDelegate(); 93 bool IsNativeUiEnabled();
94 94
95 // Called from our external delegate so they cannot be private. 95 // Called from our external delegate so they cannot be private.
96 virtual void OnFillAutofillFormData(int query_id, 96 virtual void OnFillAutofillFormData(int query_id,
97 const FormData& form, 97 const FormData& form,
98 const FormFieldData& field, 98 const FormFieldData& field,
99 int unique_id); 99 int unique_id);
100 void OnDidShowAutofillSuggestions(bool is_new_popup); 100 void OnDidShowAutofillSuggestions(bool is_new_popup);
101 void OnDidFillAutofillFormData(const base::TimeTicks& timestamp); 101 void OnDidFillAutofillFormData(const base::TimeTicks& timestamp);
102 void OnShowAutofillDialog(); 102 void OnShowAutofillDialog();
103 void OnDidPreviewAutofillFormData(); 103 void OnDidPreviewAutofillFormData();
(...skipping 332 matching lines...) Expand 10 before | Expand all | Expand 10 after
436 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 436 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
437 TestTabContentsWithExternalDelegate); 437 TestTabContentsWithExternalDelegate);
438 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, 438 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest,
439 UserHappinessFormLoadAndSubmission); 439 UserHappinessFormLoadAndSubmission);
440 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction); 440 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
441 441
442 DISALLOW_COPY_AND_ASSIGN(AutofillManager); 442 DISALLOW_COPY_AND_ASSIGN(AutofillManager);
443 }; 443 };
444 444
445 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_ 445 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_
OLDNEW
« no previous file with comments | « chrome/browser/autofill/autofill_external_delegate_unittest.cc ('k') | chrome/browser/autofill/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698