Issue 12340054: use the correct constant in the FNV1a_128_Hash function as defined in the specification

Issue 12340054: use the correct constant in the FNV1a_128_Hash function as defined in the specification (Closed)

Created:
7 years, 10 months ago by jrudolph

Modified:
7 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

use the correct constant in the FNV1a_128_Hash function as defined in the specification TEST=Use a third-party fnv1a-128 implementation to verify the test values. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184988

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -11 lines)			Patch
M	AUTHORS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/crypto/null_decrypter_test.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	net/quic/crypto/null_encrypter_test.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	net/quic/quic_utils.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Total messages: 8 (0 generated)

Ryan Hamilton

lgtm Thank you for the fix. I'm embarrassed to have made this mistake. It looks ...

7 years, 10 months ago (2013-02-26 22:48:49 UTC) #1

jrudolph

On 2013/02/26 22:48:49, Ryan Hamilton wrote: > lgtm > > Thank you for the fix. ...

7 years, 9 months ago (2013-02-27 08:18:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johannes.rudolph@googlemail.com/12340054/1

7 years, 9 months ago (2013-02-27 14:50:18 UTC) #3

commit-bot: I haz the power

Presubmit check for 12340054-1 failed and returned exit status 1. INFO:root:Found 4 file(s). INFO:PRESUBMIT:Valid authors ...

7 years, 9 months ago (2013-02-27 14:50:24 UTC) #4

jrudolph

On 2013/02/27 14:50:24, I haz the power (commit-bot) wrote: > johannes.rudolph@googlemail.com is not in AUTHORS ...

7 years, 9 months ago (2013-02-27 15:04:35 UTC) #5

Ryan Hamilton

On 2013/02/27 15:04:35, jrudolph wrote: > On 2013/02/27 14:50:24, I haz the power (commit-bot) wrote: ...

7 years, 9 months ago (2013-02-27 15:22:43 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johannes.rudolph@googlemail.com/12340054/3002

7 years, 9 months ago (2013-02-27 15:23:31 UTC) #7

Message was sent while issue was closed.

Change committed as 184988