Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 12340023: if PKG_CONFIG_PATH is already set, pkg-config-wrapper should use these dirs too (Closed)

Created:
7 years, 10 months ago by Mostyn Bramley-Moore
Modified:
7 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, chrille, Daniel Bratell, calvinlo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

if PKG_CONFIG_PATH is already set, pkg-config-wrapper should use these dirs too If PKG_CONFIG_PATH is set, then prepend these paths to those generated by the wrapper. This allows cross-compilation using sysroots with pkgconfig directories in non-standard locations. This change is safer than the original patch (https://codereview.chromium.org/12320047/), which was reverted (https://codereview.chromium.org/12317063/) due to what appears to be a chromeos builder with PKG_CONFIG_PATH set to an incomplete value (should probably be unset). Add Opera Software to the AUTHORS file BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184184

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M AUTHORS View 1 1 chunk +2 lines, -1 line 0 comments Download
M build/linux/pkg-config-wrapper View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mostyn Bramley-Moore
7 years, 10 months ago (2013-02-22 10:21:54 UTC) #1
piman
LGTM
7 years, 10 months ago (2013-02-22 18:29:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/12340023/1
7 years, 10 months ago (2013-02-22 18:29:56 UTC) #3
commit-bot: I haz the power
Failed to apply patch for AUTHORS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 10 months ago (2013-02-22 18:29:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/12340023/5001
7 years, 10 months ago (2013-02-22 18:46:10 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-22 21:45:49 UTC) #6
Message was sent while issue was closed.
Change committed as 184184

Powered by Google App Engine
This is Rietveld 408576698