Move c/b/ui/search/search.* to c/b/instant/

Move c/b/ui/search/search.* to c/b/instant/

This is the first step in a broader cleanup of the instant/search directory structure. See linked-to bug for the full list of steps.

BUG=179184
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186820

[samarth, 2013-02-27 22:12:17]

Here's the change to move search.{h,cc} to c/b/instant. I'm tempted to also
rename c/b/instant to c/b/search, but that should probably be a separate (much
larger) change.

Are you still happy with the existing chrome::search namespace for these
functions or would you prefer something else?

Thanks,
Samarth

[samarth, 2013-03-06 02:10:32]

Please take a look.

David: general review
Steven: please look at the DEPS change in c/b/favicon
Scott: can you rubberstamp?

Thanks,
Samarth

[samarth, 2013-03-06 02:10:32]

Please take a look.

David: general review
Steven: please look at the DEPS change in c/b/favicon
Scott: can you rubberstamp?

Thanks,
Samarth

[samarth, 2013-03-06 02:10:33]

Please take a look.

David: general review
Steven: please look at the DEPS change in c/b/favicon
Scott: can you rubberstamp?

Thanks,
Samarth

[stevenjb, 2013-03-06 02:30:28]

chrome/browser/favicon LGTM, thanks!

[sky, 2013-03-06 04:56:13]

Rubber stamp LGTM

[samarth, 2013-03-07 01:10:22]

Hey David,

Did you have any comments?  I'm hoping to submit this soon to avoid too much
merging.

Thanks,
Samarth

[dhollowa, 2013-03-07 01:13:38]

On 2013/03/07 01:10:22, samarth wrote:
> Hey David,
> 
> Did you have any comments?  I'm hoping to submit this soon to avoid too much
> merging.
> 
> Thanks,
> Samarth

Will look tonight.  Been held up with other fires.

[dhollowa, 2013-03-07 01:17:08]

On 2013/03/07 01:13:38, dhollowa wrote:
> On 2013/03/07 01:10:22, samarth wrote:
> > Hey David,
> > 
> > Did you have any comments?  I'm hoping to submit this soon to avoid too much
> > merging.
> > 
> > Thanks,
> > Samarth
> 
> Will look tonight.  Been held up with other fires.

Question:
From the bug:
"2. Move desktop-specific bits from c/b/instant to c/b/search (mostly everything
except for things like instant_service)"

Should be c/b/instant -> c/b/ui/search, no?

[dhollowa, 2013-03-07 02:43:56]

lgtm

[samarth, 2013-03-07 19:09:51]

On 2013/03/07 01:17:08, dhollowa wrote:
> Question:
> From the bug:
> "2. Move desktop-specific bits from c/b/instant to c/b/search (mostly
everything
> except for things like instant_service)"
> 
> Should be c/b/instant -> c/b/ui/search, no?

Yeah, my typo.  Will fix in the bug.

Thanks for taking a look quickly!
Samarth

[commit-bot: I haz the power, 2013-03-07 19:20:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/samarth@chromium.org/12335141/13001

[commit-bot: I haz the power, 2013-03-07 23:53:08]

Change committed as 186820