Issue 12335129: ARM: Fix disassembly of some VFP instructions with condition codes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12335129: ARM: Fix disassembly of some VFP instructions with condition codes (Closed)

Created:
7 years, 9 months ago by hans

Modified:
7 years, 9 months ago

Reviewers:
ulan, Rodolph Perfetta

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ARM: Fix disassembly of some VFP instructions with condition codes Previously, we would disassemble some VFP instructions like this: vmla.f64eq d16, d17, d18 This patch moves the condition to the right place: vmlaeq.f64 d16, d17, d18 Spotted by Rodolph Perfetta! BUG=none Committed: https://code.google.com/p/v8/source/detail?r=13752

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -36 lines)			Patch
	M	src/arm/disasm-arm.cc	View		8 chunks	+26 lines, -26 lines	0 comments	Download
	M	test/cctest/test-disasm-arm.cc	View		4 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

7 years, 9 months ago (2013-02-27 11:52:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r13752 (presubmit successful).

Expand Messages | Collapse Messages