Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 12335109: Strings recipes for the Dart Cookbook (Closed)

Created:
7 years, 10 months ago by shailentuli
Modified:
7 years, 4 months ago
Base URL:
https://github.com/dart-lang/cookbook.git@master
Visibility:
Public.

Description

String recipes for the Dart Cookbook. More tweaks Tweaks and formatting changes Tweaks. Removed print statements. Added Unicode string output to examples Added 2 more recipes about using regExps. Finding regExp matches. Subsitituting strings based on regExps. Added 2 more recipes. Changing string case. Determining if a string contains another string. Added 3 more recipes. Getting the length of a string. Splitting strings. subscripting strings. Wrote recipe for trimming whitespace from a string Added recipe for testing whether a string is empty. Added recipe for converting between characters and numbers. Wrote incrementally building a string using StringBuffer recipe Wrote interpolating expressions recipe Finalized text of concatenating strings recipe. Moved tests for concatenating strings into own file. Cleaned up system for aggregating tests. Added tests for string recipes. concatenating strings interpolating expressions converting between string characters and numerical codes determining if string is empty trimming whitespace from a string getting the length of a string subscripting a string that contains symbols splitting a string changing the case of a string determining whether a string contains a substring finding occurrences of a string inside another string substituting strings based on regExp matches BUG=

Patch Set 1 #

Patch Set 2 : Fixed typos. #

Total comments: 12

Patch Set 3 : Total rewrite of string recipes. #

Total comments: 55

Patch Set 4 : Numerous minor changes based on reviewers' comments. #

Total comments: 5

Patch Set 5 : Substantial rewrite of Strings recipes based on reviewers' comments. #

Patch Set 6 : Made most changes requested my Kathy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3785 lines, -0 lines) Patch
A book.asciidoc View 1 2 3 4 5 1 chunk +825 lines, -0 lines 0 comments Download
A book.html View 1 2 3 4 5 1 chunk +1551 lines, -0 lines 0 comments Download
A recipes/pubspec.lock View 1 chunk +3 lines, -0 lines 0 comments Download
A recipes/pubspec.yaml View 1 chunk +5 lines, -0 lines 0 comments Download
A recipes/src/core/strings.md View 1 2 3 4 1 chunk +677 lines, -0 lines 0 comments Download
A recipes/test/all_tests.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A recipes/test/core/core_test.dart View 1 chunk +8 lines, -0 lines 0 comments Download
A recipes/test/core/strings/calculating_the_length_test.dart View 1 2 3 4 1 chunk +39 lines, -0 lines 0 comments Download
A recipes/test/core/strings/changing_string_case_test.dart View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A recipes/test/core/strings/concatenating_strings_test.dart View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
A recipes/test/core/strings/converting_between_string_characters_test.dart View 1 2 1 chunk +80 lines, -0 lines 0 comments Download
A recipes/test/core/strings/determining_if_string_contains_test.dart View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A recipes/test/core/strings/determining_if_string_is_empty_test.dart View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
A recipes/test/core/strings/escaping_characters_test.dart View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
A recipes/test/core/strings/finding_regexp_matches_test.dart View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A recipes/test/core/strings/handling_extended_characters_test.dart View 1 2 3 4 1 chunk +41 lines, -0 lines 0 comments Download
A recipes/test/core/strings/incrementally_building_test.dart View 1 2 3 4 1 chunk +71 lines, -0 lines 0 comments Download
A recipes/test/core/strings/interpolating_expressions_test.dart View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
A recipes/test/core/strings/processing_a_string_one_character_test.dart View 1 2 3 4 1 chunk +62 lines, -0 lines 0 comments Download
A recipes/test/core/strings/removing_leading_trailing_whitespace_test.dart View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A recipes/test/core/strings/splitting_strings_test.dart View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A recipes/test/core/strings/strings_test.dart View 1 2 3 4 1 chunk +39 lines, -0 lines 0 comments Download
A recipes/test/core/strings/subscripting_a_string_test.dart View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A recipes/test/core/strings/substituting_strings_test.dart View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A recipes/test/core/strings/using_raw_strings_test.dart View 1 2 3 4 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
shailentuli
This is the first draft of 13 Strings recipes for the Cookbook. There's a ton ...
7 years, 10 months ago (2013-02-26 22:22:33 UTC) #1
shailentuli
A staged version of the recipes can be read at: https://github.com/dart-lang/cookbook/blob/strings/recipes/src/core/strings.md
7 years, 10 months ago (2013-02-26 22:22:57 UTC) #2
sethladd
As you mentioned, there's a bit of background required. Differences between codeUnit, a "character", a ...
7 years, 10 months ago (2013-02-26 23:11:54 UTC) #3
sethladd
Not finished, but thanks for doing this. It's going to be very useful. https://chromiumcodereview.appspot.com/12335109/diff/4001/recipes/src/core/strings.md File ...
7 years, 10 months ago (2013-02-26 23:41:45 UTC) #4
Cutch
In the introduction, you might want to say something like: A rune/code point map to ...
7 years, 10 months ago (2013-02-26 23:57:18 UTC) #5
shailentuli
I have just pushed a comprehensive rewrite of the string recipes for the Cookbook. You ...
7 years, 9 months ago (2013-03-07 03:35:33 UTC) #6
sethladd
https://chromiumcodereview.appspot.com/12335109/diff/9001/recipes/src/core/strings.md File recipes/src/core/strings.md (right): https://chromiumcodereview.appspot.com/12335109/diff/9001/recipes/src/core/strings.md#newcode121 recipes/src/core/strings.md:121: You want to create strings that contain Dart expressions ...
7 years, 9 months ago (2013-03-07 05:15:15 UTC) #7
floitsch
first round of comments. https://chromiumcodereview.appspot.com/12335109/diff/9001/recipes/src/core/strings.md File recipes/src/core/strings.md (right): https://chromiumcodereview.appspot.com/12335109/diff/9001/recipes/src/core/strings.md#newcode13 recipes/src/core/strings.md:13: The first plane (code points ...
7 years, 9 months ago (2013-03-07 17:22:06 UTC) #8
erikcorry
I have only glanced at it, but my first impression is that it starts out ...
7 years, 9 months ago (2013-03-07 18:26:51 UTC) #9
Alan Knight
https://chromiumcodereview.appspot.com/12335109/diff/9001/recipes/src/core/strings.md File recipes/src/core/strings.md (right): https://chromiumcodereview.appspot.com/12335109/diff/9001/recipes/src/core/strings.md#newcode3 recipes/src/core/strings.md:3: Dart string represents a sequence of characters encoded in ...
7 years, 9 months ago (2013-03-07 21:15:00 UTC) #10
shailentuli
Thank you all very much for your comments. This patch deals with minor issues brought ...
7 years, 9 months ago (2013-03-08 22:38:26 UTC) #11
floitsch
DBC. I'm also missing raw strings. https://chromiumcodereview.appspot.com/12335109/diff/9001/recipes/src/core/strings.md File recipes/src/core/strings.md (right): https://chromiumcodereview.appspot.com/12335109/diff/9001/recipes/src/core/strings.md#newcode531 recipes/src/core/strings.md:531: lower-case or upper-case, ...
7 years, 9 months ago (2013-03-09 00:01:41 UTC) #12
Lasse Reichstein Nielsen
7 years, 9 months ago (2013-03-12 11:29:37 UTC) #13
https://codereview.chromium.org/12335109/diff/17001/recipes/test/core/strings...
File recipes/test/core/strings/concatenating_strings_test.dart (right):

https://codereview.chromium.org/12335109/diff/17001/recipes/test/core/strings...
recipes/test/core/strings/concatenating_strings_test.dart:40: test(': concat()',
() {
We're renaming concat to operator+.

Powered by Google App Engine
This is Rietveld 408576698