Issue 12335103: Enable the threaded HTML parser by default

Issue 12335103: Enable the threaded HTML parser by default (Closed)

Created:
7 years, 9 months ago by abarth-chromium

Modified:
7 years, 9 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, tonyg, eseidel1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable the threaded HTML parser by default The threaded parser gets us to DOMContentLoaded about 10% faster on the telemetry top25 page set. The threaded parser also reduces the maximum stop time due to parsing by 40% on the telemetry top25 page set. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185318 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185548

Patch Set 1 #

Patch Set 2 : Now with DEPS roll #

Total comments: 1

Patch Set 3 : Align = sign #

Patch Set 4 : Without DEPS change #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
M	content/browser/web_contents/web_contents_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/content_switches.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

@darin: Would you be willing to approve this CL? I'll wait to land it until ...

7 years, 9 months ago (2013-02-26 23:04:03 UTC) #2

darin (slow to review)

LGTM https://codereview.chromium.org/12335103/diff/1006/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/12335103/diff/1006/content/public/common/content_switches.cc#newcode302 content/public/common/content_switches.cc:302: const char kDisableThreadedHTMLParser[] = "disable-threaded-html-parser"; nit: there is ...

7 years, 9 months ago (2013-02-26 23:33:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/12335103/5005

7 years, 9 months ago (2013-02-28 18:30:04 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/12335103/5005

7 years, 9 months ago (2013-03-01 17:28:49 UTC) #7

Message was sent while issue was closed.

Change committed as 185548

Expand Messages | Collapse Messages