Issue 12335024: Change eventTime field to standard chrome.* API format.

Issue 12335024: Change eventTime field to standard chrome.* API format. (Closed)

Created:
7 years, 10 months ago by miket_OOO

Modified:
7 years, 10 months ago

Reviewers:
dharcourt

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change eventTime field to standard chrome.* API format. Other timestamps in chrome.* use milliseconds since JS epoch. There isn't any good reason to deviate from that. So we don't. https://codereview.chromium.org/11299115/ brought up this issue, and unfortunately I let it languish long enough that that CL isn't easily mergeable anymore. Starting over. (thx dharcourt for getting the ball rolling.) BUG=161038 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184137

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -16 lines)			Patch
M	chrome/browser/extensions/api/notification/notification_api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/notification/notification_apitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/api/experimental_notification.idl	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	ui/message_center/notification.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/message_center/notification_list.cc	View	2 chunks	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/12335024/1

7 years, 10 months ago (2013-02-22 00:45:04 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=114406

7 years, 10 months ago (2013-02-22 02:44:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/12335024/1

7 years, 10 months ago (2013-02-22 16:43:26 UTC) #5

Message was sent while issue was closed.

Change committed as 184137

Expand Messages | Collapse Messages