content/public/test/render_view_test.cc - Issue 12335006: Add handle scopes around executeScriptAndReturnValue callsites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/render_view_test.cc

Issue 12335006: Add handle scopes around executeScriptAndReturnValue callsites (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/test/render_view_test.cc

diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc

index c896057159bc22fa78a903ffa6e56f5478fcb222..e0fb125c4e167dd2f9c04efc5dda1e73f0f100ee 100644

--- a/content/public/test/render_view_test.cc

+++ b/content/public/test/render_view_test.cc

@@ -90,6 +90,7 @@ void RenderViewTest::ExecuteJavaScript(const char* js) {

bool RenderViewTest::ExecuteJavaScriptAndReturnIntValue(

const string16& script,

int* int_result) {

+ v8::HandleScope handle_scope;

v8::Handle<v8::Value> result =

GetMainFrame()->executeScriptAndReturnValue(WebScriptSource(script));

if (result.IsEmpty() || !result->IsInt32())