Issue 12335006: Add handle scopes around executeScriptAndReturnValue callsites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12335006: Add handle scopes around executeScriptAndReturnValue callsites (Closed)

Created:
7 years, 10 months ago by dcarney

Modified:
7 years, 10 months ago

Reviewers:
drcarney, jam, jochen (gone - plz use gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, melevin, sreeram, gideonwald, dominich, Aaron Boodman, David Black, samarth+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, Jered

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add handle scopes around executeScriptAndReturnValue callsites webkit R=jochen@chromium.org TBR=jam@chromium.org BUG=https://bugs.webkit.org/show_bug.cgi?id=110206 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184024

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -1 line)			Patch
M	chrome/renderer/searchbox/searchbox_extension.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/test/render_view_test.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/browser_plugin/browser_plugin_browsertest.cc	View	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

lgtm Please file a bug and reference it in the CL description, and TBR a ...

7 years, 10 months ago (2013-02-21 16:09:34 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcarney@chromium.org/12335006/1

7 years, 10 months ago (2013-02-21 16:18:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcarney@chromium.org/12335006/1

7 years, 10 months ago (2013-02-21 22:24:32 UTC) #5

Message was sent while issue was closed.

Change committed as 184024

Expand Messages | Collapse Messages