Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chrome/browser/storage_monitor/storage_monitor.h

Issue 12334096: Regularize ownerships and lifecycle for storage monitor platform classes. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix comment name Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/storage_monitor/storage_monitor.h
diff --git a/chrome/browser/storage_monitor/storage_monitor.h b/chrome/browser/storage_monitor/storage_monitor.h
index 85b1f1be9cc01acc60e0791193180b85c88d8c2f..35247fbdbf39f8ec3f402ef6143670a25f754043 100644
--- a/chrome/browser/storage_monitor/storage_monitor.h
+++ b/chrome/browser/storage_monitor/storage_monitor.h
@@ -25,6 +25,11 @@ class TransientDeviceIds;
// Base class for platform-specific instances watching for removable storage
// attachments/detachments.
+// Lifecycle contracts: This class is created by ChromeBrowserMain
+// implementations before the profile is initialized, so listeners can be
+// created during profile construction. The platform-specific initialization,
+// which can lead to calling registered listeners with notifications of
+// attached volumes, will happen after profile construction.
class StorageMonitor {
public:
// This interface is provided to generators of storage notifications.

Powered by Google App Engine
This is Rietveld 408576698