Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: net/quic/reliable_quic_stream.cc

Issue 12334063: Land recent QUIC changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more EXPECT_FALSE Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/reliable_quic_stream.h ('k') | net/quic/test_tools/mock_clock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/reliable_quic_stream.cc
diff --git a/net/quic/reliable_quic_stream.cc b/net/quic/reliable_quic_stream.cc
index 1de1eb9b2b9bea57312445c1d34dd7b0be935be5..79b060e1235dfc0a4bfc0909f52f71d9ec4c28f8 100644
--- a/net/quic/reliable_quic_stream.cc
+++ b/net/quic/reliable_quic_stream.cc
@@ -14,7 +14,6 @@ ReliableQuicStream::ReliableQuicStream(QuicStreamId id,
QuicSession* session)
: sequencer_(this),
id_(id),
- offset_(0),
session_(session),
visitor_(NULL),
stream_bytes_read_(0),
@@ -48,21 +47,21 @@ bool ReliableQuicStream::OnStreamFrame(const QuicStreamFrame& frame) {
// We don't want to be reading: blackhole the data.
return true;
}
+ // Note: This count include duplicate data received.
+ stream_bytes_read_ += frame.data.length();
bool accepted = sequencer_.OnStreamFrame(frame);
if (frame.fin) {
- sequencer_.CloseStreamAtOffset(frame.offset + frame.data.size(),
- true);
+ sequencer_.CloseStreamAtOffset(frame.offset + frame.data.size(), true);
}
return accepted;
}
-void ReliableQuicStream::OnStreamReset(QuicErrorCode error,
- QuicStreamOffset offset) {
+void ReliableQuicStream::OnStreamReset(QuicErrorCode error) {
error_ = error;
- sequencer_.CloseStreamAtOffset(offset, false); // Full close.
+ TerminateFromPeer(false); // Full close.
}
void ReliableQuicStream::ConnectionClose(QuicErrorCode error, bool from_peer) {
@@ -84,7 +83,7 @@ void ReliableQuicStream::TerminateFromPeer(bool half_close) {
void ReliableQuicStream::Close(QuicErrorCode error) {
error_ = error;
- session()->SendRstStream(id(), error, offset_);
+ session()->SendRstStream(id(), error);
}
bool ReliableQuicStream::IsHalfClosed() const {
@@ -151,8 +150,7 @@ QuicConsumedData ReliableQuicStream::WriteDataInternal(
}
QuicConsumedData consumed_data =
- session()->WriteData(id(), data, offset_, fin);
- offset_ += consumed_data.bytes_consumed;
+ session()->WriteData(id(), data, stream_bytes_written_, fin);
stream_bytes_written_ += consumed_data.bytes_consumed;
if (consumed_data.bytes_consumed == data.length()) {
if (fin && consumed_data.fin_consumed) {
« no previous file with comments | « net/quic/reliable_quic_stream.h ('k') | net/quic/test_tools/mock_clock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698