Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: net/quic/quic_http_stream_test.cc

Issue 12334063: Land recent QUIC changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more EXPECT_FALSE Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_framer_test.cc ('k') | net/quic/quic_network_transaction_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_http_stream_test.cc
diff --git a/net/quic/quic_http_stream_test.cc b/net/quic/quic_http_stream_test.cc
index 4a5f333291d705f29d908270c08cea76123cc455..a16f2f97d8678b1f5473a7e8a812d818c92f2976 100644
--- a/net/quic/quic_http_stream_test.cc
+++ b/net/quic/quic_http_stream_test.cc
@@ -17,6 +17,7 @@
#include "net/quic/quic_connection.h"
#include "net/quic/quic_connection_helper.h"
#include "net/quic/test_tools/mock_clock.h"
+#include "net/quic/test_tools/mock_random.h"
#include "net/quic/test_tools/quic_connection_peer.h"
#include "net/quic/test_tools/quic_test_utils.h"
#include "net/quic/test_tools/test_task_runner.h"
@@ -114,7 +115,7 @@ class QuicHttpStreamTest : public ::testing::TestWithParam<bool> {
read_buffer_(new IOBufferWithSize(4096)),
guid_(2),
framer_(QuicDecrypter::Create(kNULL), QuicEncrypter::Create(kNULL)),
- creator_(guid_, &framer_) {
+ creator_(guid_, &framer_, &random_) {
IPAddressNumber ip;
CHECK(ParseIPLiteralToNumber("192.0.2.33", &ip));
peer_addr_ = IPEndPoint(ip, 443);
@@ -165,7 +166,7 @@ class QuicHttpStreamTest : public ::testing::TestWithParam<bool> {
runner_ = new TestTaskRunner(&clock_);
send_algorithm_ = new MockSendAlgorithm();
receive_algorithm_ = new TestReceiveAlgorithm(NULL);
- EXPECT_CALL(*send_algorithm_, TimeUntilSend(_)).
+ EXPECT_CALL(*send_algorithm_, TimeUntilSend(_, _)).
WillRepeatedly(testing::Return(QuicTime::Delta::Zero()));
helper_ = new QuicConnectionHelper(runner_.get(), &clock_,
&random_generator_, socket);
@@ -240,17 +241,19 @@ class QuicHttpStreamTest : public ::testing::TestWithParam<bool> {
InitializeHeader(sequence_number);
QuicAckFrame ack(largest_received, least_unacked);
+ ack.sent_info.entropy_hash = 0;
+ ack.received_info.entropy_hash = 0;
+
return ConstructPacket(header_, QuicFrame(&ack));
}
// Returns a newly created packet to send ack data.
QuicEncryptedPacket* ConstructRstPacket(
QuicPacketSequenceNumber sequence_number,
- QuicStreamId stream_id,
- QuicStreamOffset offset) {
+ QuicStreamId stream_id) {
InitializeHeader(sequence_number);
- QuicRstStreamFrame rst(stream_id, offset, QUIC_NO_ERROR);
+ QuicRstStreamFrame rst(stream_id, QUIC_NO_ERROR);
return ConstructPacket(header_, QuicFrame(&rst));
}
@@ -278,10 +281,13 @@ class QuicHttpStreamTest : public ::testing::TestWithParam<bool> {
private:
void InitializeHeader(QuicPacketSequenceNumber sequence_number) {
header_.public_header.guid = guid_;
- header_.public_header.flags = PACKET_PUBLIC_FLAGS_NONE;
+ header_.public_header.reset_flag = false;
+ header_.public_header.version_flag = false;
header_.packet_sequence_number = sequence_number;
header_.fec_group = 0;
- header_.private_flags = PACKET_PRIVATE_FLAGS_NONE;
+ header_.fec_entropy_flag = false;
+ header_.entropy_flag = false;
+ header_.fec_flag = false;
}
QuicEncryptedPacket* ConstructPacket(const QuicPacketHeader& header,
@@ -289,14 +295,15 @@ class QuicHttpStreamTest : public ::testing::TestWithParam<bool> {
QuicFrames frames;
frames.push_back(frame);
scoped_ptr<QuicPacket> packet(
- framer_.ConstructFrameDataPacket(header_, frames));
- return framer_.EncryptPacket(*packet);
+ framer_.ConstructFrameDataPacket(header_, frames).packet);
+ return framer_.EncryptPacket(header.packet_sequence_number, *packet);
}
const QuicGuid guid_;
QuicFramer framer_;
IPEndPoint self_addr_;
IPEndPoint peer_addr_;
+ MockRandom random_;
QuicPacketCreator creator_;
QuicPacketHeader header_;
scoped_ptr<StaticSocketDataProvider> socket_data_;
@@ -468,7 +475,7 @@ TEST_P(QuicHttpStreamTest, SendPostRequest) {
TEST_P(QuicHttpStreamTest, DestroyedEarly) {
SetRequestString("GET", "/");
AddWrite(SYNCHRONOUS, ConstructDataPacket(1, kFin, 0, request_data_));
- AddWrite(SYNCHRONOUS, ConstructRstPacket(2, 3, request_data_.length()));
+ AddWrite(SYNCHRONOUS, ConstructRstPacket(2, 3));
AddWrite(SYNCHRONOUS, ConstructAckPacket(3, 2, 2));
use_closing_stream_ = true;
Initialize();
« no previous file with comments | « net/quic/quic_framer_test.cc ('k') | net/quic/quic_network_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698