Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1593)

Unified Diff: net/quic/congestion_control/paced_sender_test.cc

Issue 12334063: Land recent QUIC changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more EXPECT_FALSE Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/congestion_control/paced_sender.cc ('k') | net/quic/congestion_control/quic_congestion_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/congestion_control/paced_sender_test.cc
diff --git a/net/quic/congestion_control/paced_sender_test.cc b/net/quic/congestion_control/paced_sender_test.cc
index d2432aac08933a9023f34ddbd357958eedc066e5..cc9297f8af349dd245d323baeace711a1e5e9621 100644
--- a/net/quic/congestion_control/paced_sender_test.cc
+++ b/net/quic/congestion_control/paced_sender_test.cc
@@ -19,7 +19,7 @@ class PacedSenderTest : public ::testing::Test {
protected:
PacedSenderTest()
: zero_time_(QuicTime::Delta::Zero()),
- paced_sender_(new PacedSender(&clock_,
+ paced_sender_(new PacedSender(
QuicBandwidth::FromKBytesPerSecond(kHundredKBytesPerS))) {
}
@@ -29,59 +29,48 @@ class PacedSenderTest : public ::testing::Test {
};
TEST_F(PacedSenderTest, Basic) {
- paced_sender_->UpdateBandwidthEstimate(
+ paced_sender_->UpdateBandwidthEstimate(clock_.Now(),
QuicBandwidth::FromKBytesPerSecond(kHundredKBytesPerS * 10));
- EXPECT_TRUE(paced_sender_->TimeUntilSend(zero_time_).IsZero());
- EXPECT_EQ(kMaxPacketSize * 2,
- paced_sender_->AvailableWindow(kMaxPacketSize * 4));
- paced_sender_->SentPacket(kMaxPacketSize);
- EXPECT_TRUE(paced_sender_->TimeUntilSend(zero_time_).IsZero());
- paced_sender_->SentPacket(kMaxPacketSize);
+ EXPECT_TRUE(paced_sender_->TimeUntilSend(clock_.Now(), zero_time_).IsZero());
+ paced_sender_->SentPacket(clock_.Now(), kMaxPacketSize);
+ EXPECT_TRUE(paced_sender_->TimeUntilSend(clock_.Now(), zero_time_).IsZero());
+ paced_sender_->SentPacket(clock_.Now(), kMaxPacketSize);
EXPECT_EQ(static_cast<int64>(kMaxPacketSize * 2),
- paced_sender_->TimeUntilSend(zero_time_).ToMicroseconds());
- EXPECT_EQ(0u, paced_sender_->AvailableWindow(kMaxPacketSize * 4));
+ paced_sender_->TimeUntilSend(
+ clock_.Now(), zero_time_).ToMicroseconds());
clock_.AdvanceTime(QuicTime::Delta::FromMilliseconds(24));
- EXPECT_TRUE(paced_sender_->TimeUntilSend(zero_time_).IsZero());
- EXPECT_EQ(kMaxPacketSize * 2u,
- paced_sender_->AvailableWindow(kMaxPacketSize * 4));
+ EXPECT_TRUE(paced_sender_->TimeUntilSend(clock_.Now(), zero_time_).IsZero());
}
TEST_F(PacedSenderTest, LowRate) {
- paced_sender_->UpdateBandwidthEstimate(
+ paced_sender_->UpdateBandwidthEstimate(clock_.Now(),
QuicBandwidth::FromKBytesPerSecond(kHundredKBytesPerS));
- EXPECT_TRUE(paced_sender_->TimeUntilSend(zero_time_).IsZero());
- size_t window = paced_sender_->AvailableWindow(kMaxPacketSize * 4);
- EXPECT_EQ(kMaxPacketSize * 2, window);
- paced_sender_->SentPacket(kMaxPacketSize);
- EXPECT_TRUE(paced_sender_->TimeUntilSend(zero_time_).IsZero());
- paced_sender_->SentPacket(kMaxPacketSize);
+ EXPECT_TRUE(paced_sender_->TimeUntilSend(clock_.Now(), zero_time_).IsZero());
+ paced_sender_->SentPacket(clock_.Now(), kMaxPacketSize);
+ EXPECT_TRUE(paced_sender_->TimeUntilSend(clock_.Now(), zero_time_).IsZero());
+ paced_sender_->SentPacket(clock_.Now(), kMaxPacketSize);
EXPECT_EQ(static_cast<int64>(kMaxPacketSize * 20),
- paced_sender_->TimeUntilSend(zero_time_).ToMicroseconds());
- EXPECT_EQ(0u, paced_sender_->AvailableWindow(kMaxPacketSize * 4));
+ paced_sender_->TimeUntilSend(
+ clock_.Now(), zero_time_).ToMicroseconds());
clock_.AdvanceTime(QuicTime::Delta::FromMilliseconds(24));
- EXPECT_TRUE(paced_sender_->TimeUntilSend(zero_time_).IsZero());
- EXPECT_EQ(kMaxPacketSize * 2,
- paced_sender_->AvailableWindow(kMaxPacketSize * 4));
+ EXPECT_TRUE(paced_sender_->TimeUntilSend(clock_.Now(), zero_time_).IsZero());
}
TEST_F(PacedSenderTest, HighRate) {
QuicBandwidth bandwidth_estimate = QuicBandwidth::FromKBytesPerSecond(
kHundredKBytesPerS * 100);
- paced_sender_->UpdateBandwidthEstimate(bandwidth_estimate);
- EXPECT_TRUE(paced_sender_->TimeUntilSend(zero_time_).IsZero());
- EXPECT_EQ(static_cast<uint64>(bandwidth_estimate.ToBytesPerSecond() / 500u),
- paced_sender_->AvailableWindow(kMaxPacketSize * 100));
+ paced_sender_->UpdateBandwidthEstimate(clock_.Now(), bandwidth_estimate);
+ EXPECT_TRUE(paced_sender_->TimeUntilSend(clock_.Now(), zero_time_).IsZero());
for (int i = 0; i < 16; ++i) {
- paced_sender_->SentPacket(kMaxPacketSize);
- EXPECT_TRUE(paced_sender_->TimeUntilSend(zero_time_).IsZero());
+ paced_sender_->SentPacket(clock_.Now(), kMaxPacketSize);
+ EXPECT_TRUE(paced_sender_->TimeUntilSend(
+ clock_.Now(), zero_time_).IsZero());
}
- paced_sender_->SentPacket(kMaxPacketSize);
- EXPECT_EQ(0u, paced_sender_->AvailableWindow(kMaxPacketSize * 100));
- EXPECT_EQ(2040, paced_sender_->TimeUntilSend(zero_time_).ToMicroseconds());
+ paced_sender_->SentPacket(clock_.Now(), kMaxPacketSize);
+ EXPECT_EQ(2040, paced_sender_->TimeUntilSend(
+ clock_.Now(), zero_time_).ToMicroseconds());
clock_.AdvanceTime(QuicTime::Delta::FromMicroseconds(20400));
- EXPECT_TRUE(paced_sender_->TimeUntilSend(zero_time_).IsZero());
- EXPECT_EQ(static_cast<uint64>(bandwidth_estimate.ToBytesPerSecond() / 500u),
- paced_sender_->AvailableWindow(kMaxPacketSize * 100));
+ EXPECT_TRUE(paced_sender_->TimeUntilSend(clock_.Now(), zero_time_).IsZero());
}
} // namespace test
« no previous file with comments | « net/quic/congestion_control/paced_sender.cc ('k') | net/quic/congestion_control/quic_congestion_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698