Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Side by Side Diff: net/quic/quic_fec_group.cc

Issue 12334063: Land recent QUIC changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more EXPECT_FALSE Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/quic/quic_fec_group.h ('k') | net/quic/quic_fec_group_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_fec_group.h" 5 #include "net/quic/quic_fec_group.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 10
11 using base::StringPiece; 11 using base::StringPiece;
12 using std::numeric_limits; 12 using std::numeric_limits;
13 using std::set; 13 using std::set;
14 14
15 namespace net { 15 namespace net {
16 16
17 namespace { 17 namespace {
18 const QuicPacketSequenceNumber kNoSequenceNumber = kuint64max; 18 const QuicPacketSequenceNumber kNoSequenceNumber = kuint64max;
19 } // namespace 19 } // namespace
20 20
21 QuicFecGroup::QuicFecGroup() 21 QuicFecGroup::QuicFecGroup()
22 : min_protected_packet_(kNoSequenceNumber), 22 : min_protected_packet_(kNoSequenceNumber),
23 max_protected_packet_(kNoSequenceNumber), 23 max_protected_packet_(kNoSequenceNumber),
24 parity_len_(0) { 24 payload_parity_len_(0),
25 entropy_parity_(false) {
25 } 26 }
26 27
27 QuicFecGroup::~QuicFecGroup() {} 28 QuicFecGroup::~QuicFecGroup() {}
28 29
29 bool QuicFecGroup::Update(const QuicPacketHeader& header, 30 bool QuicFecGroup::Update(const QuicPacketHeader& header,
30 StringPiece decrypted_payload) { 31 StringPiece decrypted_payload) {
31 if (received_packets_.count(header.packet_sequence_number) != 0) { 32 if (received_packets_.count(header.packet_sequence_number) != 0) {
32 return false; 33 return false;
33 } 34 }
34 if (min_protected_packet_ != kNoSequenceNumber && 35 if (min_protected_packet_ != kNoSequenceNumber &&
35 max_protected_packet_ != kNoSequenceNumber && 36 max_protected_packet_ != kNoSequenceNumber &&
36 (header.packet_sequence_number < min_protected_packet_ || 37 (header.packet_sequence_number < min_protected_packet_ ||
37 header.packet_sequence_number > max_protected_packet_)) { 38 header.packet_sequence_number > max_protected_packet_)) {
38 DLOG(ERROR) << "FEC group does not cover received packet: " 39 DLOG(ERROR) << "FEC group does not cover received packet: "
39 << header.packet_sequence_number; 40 << header.packet_sequence_number;
40 return false; 41 return false;
41 } 42 }
42 if (!UpdateParity(decrypted_payload)) { 43 if (!UpdateParity(decrypted_payload, header.entropy_flag)) {
43 return false; 44 return false;
44 } 45 }
45 received_packets_.insert(header.packet_sequence_number); 46 received_packets_.insert(header.packet_sequence_number);
46 return true; 47 return true;
47 } 48 }
48 49
49 bool QuicFecGroup::UpdateFec( 50 bool QuicFecGroup::UpdateFec(
50 QuicPacketSequenceNumber fec_packet_sequence_number, 51 QuicPacketSequenceNumber fec_packet_sequence_number,
52 bool fec_entropy_flag,
51 const QuicFecData& fec) { 53 const QuicFecData& fec) {
52 if (min_protected_packet_ != kNoSequenceNumber) { 54 if (min_protected_packet_ != kNoSequenceNumber) {
53 return false; 55 return false;
54 } 56 }
55 set<QuicPacketSequenceNumber>::const_iterator it = received_packets_.begin(); 57 SequenceNumberSet::const_iterator it = received_packets_.begin();
56 while (it != received_packets_.end()) { 58 while (it != received_packets_.end()) {
57 if ((*it < fec.fec_group) || 59 if ((*it < fec.fec_group) ||
58 (*it >= fec_packet_sequence_number)) { 60 (*it >= fec_packet_sequence_number)) {
59 DLOG(ERROR) << "FEC group does not cover received packet: " << *it; 61 DLOG(ERROR) << "FEC group does not cover received packet: " << *it;
60 return false; 62 return false;
61 } 63 }
62 ++it; 64 ++it;
63 } 65 }
64 if (!UpdateParity(fec.redundancy)) { 66 if (!UpdateParity(fec.redundancy, fec_entropy_flag)) {
65 return false; 67 return false;
66 } 68 }
67 min_protected_packet_ = fec.fec_group; 69 min_protected_packet_ = fec.fec_group;
68 max_protected_packet_ = fec_packet_sequence_number - 1; 70 max_protected_packet_ = fec_packet_sequence_number - 1;
69 return true; 71 return true;
70 } 72 }
71 73
72 bool QuicFecGroup::CanRevive() const { 74 bool QuicFecGroup::CanRevive() const {
73 // We can revive if we're missing exactly 1 packet. 75 // We can revive if we're missing exactly 1 packet.
74 return NumMissingPackets() == 1; 76 return NumMissingPackets() == 1;
(...skipping 16 matching lines...) Expand all
91 for (QuicPacketSequenceNumber i = min_protected_packet_; 93 for (QuicPacketSequenceNumber i = min_protected_packet_;
92 i <= max_protected_packet_; ++i) { 94 i <= max_protected_packet_; ++i) {
93 // Is this packet missing? 95 // Is this packet missing?
94 if (received_packets_.count(i) == 0) { 96 if (received_packets_.count(i) == 0) {
95 missing = i; 97 missing = i;
96 break; 98 break;
97 } 99 }
98 } 100 }
99 DCHECK_NE(kNoSequenceNumber, missing); 101 DCHECK_NE(kNoSequenceNumber, missing);
100 102
101 DCHECK_LE(parity_len_, decrypted_payload_len); 103 DCHECK_LE(payload_parity_len_, decrypted_payload_len);
102 if (parity_len_ > decrypted_payload_len) { 104 if (payload_parity_len_ > decrypted_payload_len) {
103 return 0; 105 return 0;
104 } 106 }
105 for (size_t i = 0; i < parity_len_; ++i) { 107 for (size_t i = 0; i < payload_parity_len_; ++i) {
106 decrypted_payload[i] = parity_[i]; 108 decrypted_payload[i] = payload_parity_[i];
107 } 109 }
110
108 header->packet_sequence_number = missing; 111 header->packet_sequence_number = missing;
112 header->entropy_flag = entropy_parity_;
113
109 received_packets_.insert(missing); 114 received_packets_.insert(missing);
110 return parity_len_; 115 return payload_parity_len_;
111 } 116 }
112 117
113 bool QuicFecGroup::ProtectsPacketsBefore(QuicPacketSequenceNumber num) const { 118 bool QuicFecGroup::ProtectsPacketsBefore(QuicPacketSequenceNumber num) const {
114 if (max_protected_packet_ != kNoSequenceNumber) { 119 if (max_protected_packet_ != kNoSequenceNumber) {
115 return max_protected_packet_ < num; 120 return max_protected_packet_ < num;
116 } 121 }
117 // Since we might not yet have recevied the FEC packet, we must check 122 // Since we might not yet have recevied the FEC packet, we must check
118 // the packets we have received. 123 // the packets we have received.
119 return *received_packets_.begin() < num; 124 return *received_packets_.begin() < num;
120 } 125 }
121 126
122 bool QuicFecGroup::UpdateParity(StringPiece payload) { 127 bool QuicFecGroup::UpdateParity(StringPiece payload, bool entropy) {
123 DCHECK_LE(payload.size(), kMaxPacketSize); 128 DCHECK_LE(payload.size(), kMaxPacketSize);
124 if (payload.size() > kMaxPacketSize) { 129 if (payload.size() > kMaxPacketSize) {
125 DLOG(ERROR) << "Illegal payload size: " << payload.size(); 130 DLOG(ERROR) << "Illegal payload size: " << payload.size();
126 return false; 131 return false;
127 } 132 }
128 if (parity_len_ < payload.size()) { 133 if (payload_parity_len_ < payload.size()) {
129 parity_len_ = payload.size(); 134 payload_parity_len_ = payload.size();
130 } 135 }
131 DCHECK_LE(payload.size(), kMaxPacketSize); 136 DCHECK_LE(payload.size(), kMaxPacketSize);
132 if (received_packets_.size() == 0 && 137 if (received_packets_.size() == 0 &&
133 min_protected_packet_ == kNoSequenceNumber) { 138 min_protected_packet_ == kNoSequenceNumber) {
134 // Initialize the parity to the value of this payload 139 // Initialize the parity to the value of this payload
135 memcpy(parity_, payload.data(), payload.size()); 140 memcpy(payload_parity_, payload.data(), payload.size());
136 if (payload.size() < kMaxPacketSize) { 141 if (payload.size() < kMaxPacketSize) {
137 // TODO(rch): expand as needed. 142 // TODO(rch): expand as needed.
138 memset(parity_ + payload.size(), 0, 143 memset(payload_parity_ + payload.size(), 0,
139 kMaxPacketSize - payload.size()); 144 kMaxPacketSize - payload.size());
140 } 145 }
146 entropy_parity_ = entropy;
141 return true; 147 return true;
142 } 148 }
143 // Update the parity by XORing in the data (padding with 0s if necessary). 149 // Update the parity by XORing in the data (padding with 0s if necessary).
144 for (size_t i = 0; i < kMaxPacketSize; ++i) { 150 for (size_t i = 0; i < kMaxPacketSize; ++i) {
145 uint8 byte = i < payload.size() ? payload[i] : 0x00; 151 uint8 byte = i < payload.size() ? payload[i] : 0x00;
146 parity_[i] ^= byte; 152 payload_parity_[i] ^= byte;
147 } 153 }
154 // xor of boolean values.
155 entropy_parity_ = (entropy_parity_ != entropy);
148 return true; 156 return true;
149 } 157 }
150 158
151 size_t QuicFecGroup::NumMissingPackets() const { 159 size_t QuicFecGroup::NumMissingPackets() const {
152 if (min_protected_packet_ == kNoSequenceNumber) 160 if (min_protected_packet_ == kNoSequenceNumber)
153 return numeric_limits<size_t>::max(); 161 return numeric_limits<size_t>::max();
154 return (max_protected_packet_ - min_protected_packet_ + 1) - 162 return (max_protected_packet_ - min_protected_packet_ + 1) -
155 received_packets_.size(); 163 received_packets_.size();
156 } 164 }
157 165
158 } // namespace net 166 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_fec_group.h ('k') | net/quic/quic_fec_group_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698