Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 12334041: Enable accelerated animations for orphaned layers (Closed)

Created:
7 years, 10 months ago by ajuma
Modified:
7 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, apatrick_chromium
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Enable accelerated animations for orphan layers This defines RenderWidgetCompositor::registerForAnimations, which associates the LayerAnimationController of newly-created cc::Layers with the AnimationRegistrar of the RenderWidgetCompositor's LayerTreeHost. This also makes cc::Layer::addAnimation accept animations whenever the layer's LayerAnimationController has an AnimationRegistrar, and makes LayerTreeHost only create an AnimationRegistrar when accelerated animations are enabled. BUG=129683 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184488

Patch Set 1 #

Patch Set 2 : Fix android_dbg_triggered_tests #

Total comments: 1

Patch Set 3 : Also test LTH with no registrar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -31 lines) Patch
M cc/layer.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M cc/layer_animation_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layer_tree_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layer_unittest.cc View 1 2 2 chunks +22 lines, -16 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
ajuma
This depends on https://bugs.webkit.org/show_bug.cgi?id=106594
7 years, 10 months ago (2013-02-22 22:33:07 UTC) #1
Ian Vollick
On 2013/02/22 22:33:07, ajuma wrote: > This depends on https://bugs.webkit.org/show_bug.cgi?id=106594 lgtm.
7 years, 10 months ago (2013-02-22 22:55:55 UTC) #2
ajuma
+kbr for content/renderer/gpu OWNERS.
7 years, 10 months ago (2013-02-22 23:21:29 UTC) #3
Ken Russell (switch to Gerrit)
lgtm
7 years, 10 months ago (2013-02-23 00:22:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/12334041/1
7 years, 10 months ago (2013-02-24 21:03:15 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-24 21:21:14 UTC) #6
ajuma
On 2013/02/24 21:21:14, I haz the power (commit-bot) wrote: > Sorry for I got bad ...
7 years, 10 months ago (2013-02-24 21:29:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/12334041/1
7 years, 10 months ago (2013-02-24 21:30:14 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-24 21:49:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/12334041/1
7 years, 10 months ago (2013-02-24 21:58:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/12334041/1
7 years, 10 months ago (2013-02-25 14:12:07 UTC) #11
ajuma
Patch updated to fix LayerLayerTreeHostTest.shouldNotAddAnimationWithoutLayerTreeHost. vollick@, PTAL.
7 years, 10 months ago (2013-02-25 18:18:47 UTC) #12
Ian Vollick
https://codereview.chromium.org/12334041/diff/4008/cc/layer_unittest.cc File cc/layer_unittest.cc (right): https://codereview.chromium.org/12334041/diff/4008/cc/layer_unittest.cc#newcode865 cc/layer_unittest.cc:865: // Case 3: with a LayerTreeHost, the animation should ...
7 years, 10 months ago (2013-02-25 18:27:29 UTC) #13
ajuma
On 2013/02/25 18:27:29, vollick wrote: > https://codereview.chromium.org/12334041/diff/4008/cc/layer_unittest.cc > File cc/layer_unittest.cc (right): > > https://codereview.chromium.org/12334041/diff/4008/cc/layer_unittest.cc#newcode865 > ...
7 years, 10 months ago (2013-02-25 18:43:16 UTC) #14
Ian Vollick
On 2013/02/25 18:43:16, ajuma wrote: > On 2013/02/25 18:27:29, vollick wrote: > > https://codereview.chromium.org/12334041/diff/4008/cc/layer_unittest.cc > ...
7 years, 10 months ago (2013-02-25 18:47:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/12334041/7007
7 years, 10 months ago (2013-02-25 18:49:36 UTC) #16
commit-bot: I haz the power
7 years, 10 months ago (2013-02-25 21:48:43 UTC) #17
Message was sent while issue was closed.
Change committed as 184488

Powered by Google App Engine
This is Rietveld 408576698