Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Issue 12334038: Disable pyauto for Win64 build (Closed)

Created:
7 years, 10 months ago by jschuh
Modified:
7 years, 10 months ago
Reviewers:
kkania, Nico, anantha
CC:
chromium-reviews
Visibility:
Public.

Description

Disable pyauto for Win64 build Pyauto doesn't build on Win64 due to several issues. Since it's deprecated it may not be worth the effort of fixing, but in the immediate term I need it disabled for just the Win64 build. BUG=177664 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184171

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M build/all.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jschuh
the title says it all.
7 years, 10 months ago (2013-02-22 14:25:53 UTC) #1
jschuh
@thakis - src/chrome Owners TBR @anantha - For sign-off on disabling pyauto (at least temporarily) ...
7 years, 10 months ago (2013-02-22 17:38:55 UTC) #2
jschuh
So, I'm told that @kkania might be appropriate to approve this CL.
7 years, 10 months ago (2013-02-22 18:01:24 UTC) #3
kkania
lgtm https://codereview.chromium.org/12334038/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12334038/diff/1/build/common.gypi#newcode1034 build/common.gypi:1034: # TODO(jaschuh): crbug.com/177664 Investigate Win64 pyauto build. jschuh
7 years, 10 months ago (2013-02-22 18:16:38 UTC) #4
jschuh
On 2013/02/22 18:16:38, kkania wrote: > lgtm > > https://codereview.chromium.org/12334038/diff/1/build/common.gypi > File build/common.gypi (right): > ...
7 years, 10 months ago (2013-02-22 18:22:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12334038/6001
7 years, 10 months ago (2013-02-22 18:24:27 UTC) #6
commit-bot: I haz the power
Change committed as 184171
7 years, 10 months ago (2013-02-22 21:02:09 UTC) #7
Nico
7 years, 10 months ago (2013-02-25 09:25:42 UTC) #8
Message was sent while issue was closed.
lgtm stamp

Powered by Google App Engine
This is Rietveld 408576698