ffmpeg_unittests should depend on use_ffmpeg==1

ffmpeg_unittests should depend on use_ffmpeg==1

This target currently makes assumptions based on the platform, even though there's an explicit variable that was previously set for this purpose.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184320

[stuartmorgan, 2013-02-22 12:35:39]

LGTM

(The condition predates the creation of use_ffmgpeg, FYI)

[blundell, 2013-02-22 12:38:18]

LGTM

Thanks for the cleanup!

[Mostyn Bramley-Moore, 2013-02-22 15:29:55]

Is someone able to submit this to the try server/integration queue for me?

[scherkus (not reviewing), 2013-02-22 18:44:19]

nit: can you remove the empty "BUG=" from the CL description?

LGTM -- feel free to check the commit box

[commit-bot: I haz the power, 2013-02-22 20:42:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/12334037/1

[Mostyn Bramley-Moore, 2013-02-22 20:42:22]

On 2013/02/22 18:44:19, scherkus wrote:
> nit: can you remove the empty "BUG=" from the CL description?
> 
> LGTM -- feel free to check the commit box

Done and done.

[commit-bot: I haz the power, 2013-02-22 20:42:24]

Presubmit check for 12334037-1 failed and returned exit status 1.

INFO:root:Found 1 file(s).
INFO:PRESUBMIT:Valid authors are *@chromium.org, *@google.com,
ibraaaa@gmail.com, rryk.ua@gmail.com, sanxiyn@gmail.com, alexscheele@gmail.com,
me@bramp.net, phajdan.jr@gmail.com, jesse@jmiller.biz, szymonpiechowicz@o2.pl,
vega.james@gmail.com, gothicx@gmail.com, reimarvin@gmail.com,
drpizza@quiscalusmexicanus.org, developer0420@gmail.com, yado.masa@gmail.com,
yarin.kaul@gmail.com, mendola@gmail.com, craig.schlenter@gmail.com,
ibrar.ahmad@gmail.com, takano.naoki@gmail.com, fta@sofaraway.org,
kunalt@gmail.com, m0.interactive@gmail.com, jroesslein@gmail.com,
sy3620@gmail.com, bekkra@gmail.com, raman.tenneti@gmail.com, kpn24@drexel.edu,
kimworking@gmail.com, paulrobinson85@googlemail.com, jorat1346@gmail.com,
tedoc2000@gmail.com, himikof@gmail.com, sean@cyberwang.net,
rsesek@bluestatic.org, j.dinata@gmail.com, chromium@willhirsch.co.uk,
yoav.zilberberg@gmail.com, joel@jms.id.au, jacob@mandelson.org,
yuri.gorobets@gmail.com, pwicks86@gmail.com, thiago.farina@gmail.com,
viettrungluu@gmail.com, pierre.lafayette@gmail.com, ffmpeg@gmail.com,
philippe.beauchamp@gmail.com, vedran.sajatovic@gmail.com,
randy.posynick@gmail.com, bruno@flock.com, jsorianopastor@gmail.com,
bdonlan@gmail.com, artagnon@gmail.com, dominic.jodoin@gmail.com,
googlecontrib@velox.ch, clemens@endorphin.org, sig11@reprehensible.net,
voyageur@gentoo.org, vt@foilhead.net, alexander@sulfrian.net,
philippe.beaudoin@gmail.com, mhahnenb@andrew.cmu.edu, agartrell@cmu.edu,
leith@leithalweapon.geek.nz, jchoi42@pha.jhu.edu, paul.l.kehrer@gmail.com,
chamalsl@yahoo.com, jaysoffian@gmail.com, bgmerrell@gmail.com,
appamatto@gmail.com, bgmerrell@gmail.com, ryan-chromium-dev@sleevi.com,
satoshi.matsuzaki@gmail.com, pcgod99@gmail.com, ningxin.hu@intel.com,
james.wei@intel.com, haitao.feng@intel.com, weinjared@gmail.com,
melvinxie@gmail.com, floppymaster@gmail.com, giuseppe@iuculano.it,
jwillcox@litl.com, v.a.shreyas@gmail.com, spenn@engr.uvic.ca,
jorge@tomatocannon.com, pnettleship@gmail.com, davidben@mit.edu,
venture37@geeklan.co.uk, peter@chromium.org, lauri.oherd@gmail.com,
eschew@gmail.com, sam@sammcd.com, fuzzac@gmail.com, kushi.p@gmail.com,
m.b.lankhorst@gmail.com, vipul.bhasin@gmail.com, rnorton10@gmail.com,
dill.sellars@gmail.com, seshadri.mahalingam@gmail.com, clementskau@gmail.com,
david.mike.futcher@gmail.com, ramkumar.gokarnesan@gmail.com,
mma.public@gmail.com, chromium@hybridsource.org, *@nvidia.com,
google@tk-webart.de, pph34r@gmail.com, lukezarko@gmail.com, fhd@ubercode.de,
ali.akbar@gmail.com, mathias@qiwi.be, mrs@mythic-beasts.com,
amruthraj@motorola.com, ckqr36@motorola.com, wxjg68@motorola.com,
ehsan.akhgari@gmail.com, chrelad@gmail.com, ncj674@motorola.com,
mtilburg@adobe.com, pbrophy@adobe.com, goldberg@adobe.com, woodward@adobe.com,
vinaya@adobe.com, naveenbobbili@motorola.com, vamshi@motorola.com,
robert.nagy@gmail.com, qtc746@motorola.com, blr.bmlab@gmail.com,
wrm364@motorola.com, rosen.dash@gmail.com, qghc36@motorola.com,
ravi.kasibhatla@motorola.com, nqk836@motorola.com, nrqv63@motorola.com,
tedvessenes@gmail.com, progame@chromium.org, brk376@motorola.com,
cristian.patrasciuc@gmail.com, halton.huo@intel.com, aofdwsl@gmail.com,
gaochun.dev@gmail.com, clintstaley@gmail.com, clintstaley@chromium.org,
rdevlin.cronin@gmail.com, junmin.zhu@intel.com, cem.kocagil@gmail.com,
simon.hong81@gmail.com, guanqun.lu@gmail.com, beaufort.francois@gmail.com,
eriq.augustine@gmail.com, francoisk777@gmail.com, erikghill@gmail.com,
maojie0924@gmail.com, pan.deng@intel.com, aaronlevbugs@gmail.com,
peter@pcc.me.uk, aaron.randolph@gmail.com, yumios.art@gmail.com,
matthewrobertson03@gmail.com, yujie.mao@intel.com, samuel.xu@intel.com,
jin.a.yang@intel.com, hexinchao@gmail.com, changbin.shao@intel.com,
stephen.searles@gmail.com, arun.m@samsung.com, trprice@gmail.com,
achicu@adobe.com, ekr@rtfm.com, wiss1976@gmail.com, erik.sjolund@gmail.com,
simon.arlott@gmail.com, alexkorep@gmail.com, mitchellwrosen@chromium.org,
yongsheng.zhu@intel.com, shouqun.liu@intel.com, kangyuan.shu@intel.com,
jake@helfert.us, hongbo.min@intel.com, tom.cassiotis@gmail.com,
evangelos@foutrelis.com, paivanof@gmail.com, rb@radix.io, petarj@mips.com,
carloschilazo@gmail.com, mmaerean@adobe.com, kaustubh.ra@gmail.com,
betravis@adobe.com, bear.travis@gmail.com, mvujovic@adobe.com,
jakob.j.w@googlemail.com, badea@adobe.com, joshua.lock@intel.com,
chunyang.dai@intel.com, mhx348@motorola.com, rubentopo@gmail.com,
josh.triplett@intel.com, qiankun.miao@intel.com, etienne@atnnn.com,
yang.gu@intel.com, ttr314@googlemail.com, limasdf@gmail.com,
m.s.bednorz@gmail.com, kamil.jiwa@gmail.com, keenepan@linpus.com,
unsafe@trevp.net, rosca@adobe.com, sylvinus@gmail.com, sungmann.cho@gmail.com,
fangjue23303@gmail.com, evan.peterson.ep@gmail.com, jryans@chromium.org,
matheusbrat@gmail.com, olaru@adobe.com, horia.olaru@gmail.com

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit Warnings **
mostynb@opera.com is not in AUTHORS file. If you are a new contributor, please
visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

Presubmit checks took 1.1s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2013-02-22 20:43:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/12334037/1

[commit-bot: I haz the power, 2013-02-22 20:43:31]

Presubmit check for 12334037-1 failed and returned exit status 1.

INFO:root:Found 1 file(s).
INFO:PRESUBMIT:Valid authors are *@chromium.org, *@google.com,
ibraaaa@gmail.com, rryk.ua@gmail.com, sanxiyn@gmail.com, alexscheele@gmail.com,
me@bramp.net, phajdan.jr@gmail.com, jesse@jmiller.biz, szymonpiechowicz@o2.pl,
vega.james@gmail.com, gothicx@gmail.com, reimarvin@gmail.com,
drpizza@quiscalusmexicanus.org, developer0420@gmail.com, yado.masa@gmail.com,
yarin.kaul@gmail.com, mendola@gmail.com, craig.schlenter@gmail.com,
ibrar.ahmad@gmail.com, takano.naoki@gmail.com, fta@sofaraway.org,
kunalt@gmail.com, m0.interactive@gmail.com, jroesslein@gmail.com,
sy3620@gmail.com, bekkra@gmail.com, raman.tenneti@gmail.com, kpn24@drexel.edu,
kimworking@gmail.com, paulrobinson85@googlemail.com, jorat1346@gmail.com,
tedoc2000@gmail.com, himikof@gmail.com, sean@cyberwang.net,
rsesek@bluestatic.org, j.dinata@gmail.com, chromium@willhirsch.co.uk,
yoav.zilberberg@gmail.com, joel@jms.id.au, jacob@mandelson.org,
yuri.gorobets@gmail.com, pwicks86@gmail.com, thiago.farina@gmail.com,
viettrungluu@gmail.com, pierre.lafayette@gmail.com, ffmpeg@gmail.com,
philippe.beauchamp@gmail.com, vedran.sajatovic@gmail.com,
randy.posynick@gmail.com, bruno@flock.com, jsorianopastor@gmail.com,
bdonlan@gmail.com, artagnon@gmail.com, dominic.jodoin@gmail.com,
googlecontrib@velox.ch, clemens@endorphin.org, sig11@reprehensible.net,
voyageur@gentoo.org, vt@foilhead.net, alexander@sulfrian.net,
philippe.beaudoin@gmail.com, mhahnenb@andrew.cmu.edu, agartrell@cmu.edu,
leith@leithalweapon.geek.nz, jchoi42@pha.jhu.edu, paul.l.kehrer@gmail.com,
chamalsl@yahoo.com, jaysoffian@gmail.com, bgmerrell@gmail.com,
appamatto@gmail.com, bgmerrell@gmail.com, ryan-chromium-dev@sleevi.com,
satoshi.matsuzaki@gmail.com, pcgod99@gmail.com, ningxin.hu@intel.com,
james.wei@intel.com, haitao.feng@intel.com, weinjared@gmail.com,
melvinxie@gmail.com, floppymaster@gmail.com, giuseppe@iuculano.it,
jwillcox@litl.com, v.a.shreyas@gmail.com, spenn@engr.uvic.ca,
jorge@tomatocannon.com, pnettleship@gmail.com, davidben@mit.edu,
venture37@geeklan.co.uk, peter@chromium.org, lauri.oherd@gmail.com,
eschew@gmail.com, sam@sammcd.com, fuzzac@gmail.com, kushi.p@gmail.com,
m.b.lankhorst@gmail.com, vipul.bhasin@gmail.com, rnorton10@gmail.com,
dill.sellars@gmail.com, seshadri.mahalingam@gmail.com, clementskau@gmail.com,
david.mike.futcher@gmail.com, ramkumar.gokarnesan@gmail.com,
mma.public@gmail.com, chromium@hybridsource.org, *@nvidia.com,
google@tk-webart.de, pph34r@gmail.com, lukezarko@gmail.com, fhd@ubercode.de,
ali.akbar@gmail.com, mathias@qiwi.be, mrs@mythic-beasts.com,
amruthraj@motorola.com, ckqr36@motorola.com, wxjg68@motorola.com,
ehsan.akhgari@gmail.com, chrelad@gmail.com, ncj674@motorola.com,
mtilburg@adobe.com, pbrophy@adobe.com, goldberg@adobe.com, woodward@adobe.com,
vinaya@adobe.com, naveenbobbili@motorola.com, vamshi@motorola.com,
robert.nagy@gmail.com, qtc746@motorola.com, blr.bmlab@gmail.com,
wrm364@motorola.com, rosen.dash@gmail.com, qghc36@motorola.com,
ravi.kasibhatla@motorola.com, nqk836@motorola.com, nrqv63@motorola.com,
tedvessenes@gmail.com, progame@chromium.org, brk376@motorola.com,
cristian.patrasciuc@gmail.com, halton.huo@intel.com, aofdwsl@gmail.com,
gaochun.dev@gmail.com, clintstaley@gmail.com, clintstaley@chromium.org,
rdevlin.cronin@gmail.com, junmin.zhu@intel.com, cem.kocagil@gmail.com,
simon.hong81@gmail.com, guanqun.lu@gmail.com, beaufort.francois@gmail.com,
eriq.augustine@gmail.com, francoisk777@gmail.com, erikghill@gmail.com,
maojie0924@gmail.com, pan.deng@intel.com, aaronlevbugs@gmail.com,
peter@pcc.me.uk, aaron.randolph@gmail.com, yumios.art@gmail.com,
matthewrobertson03@gmail.com, yujie.mao@intel.com, samuel.xu@intel.com,
jin.a.yang@intel.com, hexinchao@gmail.com, changbin.shao@intel.com,
stephen.searles@gmail.com, arun.m@samsung.com, trprice@gmail.com,
achicu@adobe.com, ekr@rtfm.com, wiss1976@gmail.com, erik.sjolund@gmail.com,
simon.arlott@gmail.com, alexkorep@gmail.com, mitchellwrosen@chromium.org,
yongsheng.zhu@intel.com, shouqun.liu@intel.com, kangyuan.shu@intel.com,
jake@helfert.us, hongbo.min@intel.com, tom.cassiotis@gmail.com,
evangelos@foutrelis.com, paivanof@gmail.com, rb@radix.io, petarj@mips.com,
carloschilazo@gmail.com, mmaerean@adobe.com, kaustubh.ra@gmail.com,
betravis@adobe.com, bear.travis@gmail.com, mvujovic@adobe.com,
jakob.j.w@googlemail.com, badea@adobe.com, joshua.lock@intel.com,
chunyang.dai@intel.com, mhx348@motorola.com, rubentopo@gmail.com,
josh.triplett@intel.com, qiankun.miao@intel.com, etienne@atnnn.com,
yang.gu@intel.com, ttr314@googlemail.com, limasdf@gmail.com,
m.s.bednorz@gmail.com, kamil.jiwa@gmail.com, keenepan@linpus.com,
unsafe@trevp.net, rosca@adobe.com, sylvinus@gmail.com, sungmann.cho@gmail.com,
fangjue23303@gmail.com, evan.peterson.ep@gmail.com, jryans@chromium.org,
matheusbrat@gmail.com, olaru@adobe.com, horia.olaru@gmail.com

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit Warnings **
mostynb@opera.com is not in AUTHORS file. If you are a new contributor, please
visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

Presubmit checks took 1.3s to calculate.

[Mostyn Bramley-Moore, 2013-02-22 20:48:29]

I have another patch in the integration queue which fixes the AUTHORS file
issue:
https://codereview.chromium.org/12340023/

If 12340023 passes and is integrated, and then I re-check the commit box, will
the presubmit check be done after merging to mainline?

[scherkus (not reviewing), 2013-02-22 20:53:32]

On 2013/02/22 20:48:29, Mostyn Bramley-Moore wrote:
> I have another patch in the integration queue which fixes the AUTHORS file
> issue:
> https://codereview.chromium.org/12340023/
> 
> If 12340023 passes and is integrated, and then I re-check the commit box, will
> the presubmit check be done after merging to mainline?

I believe so! If it doesn't work ping this CR and we can take care of it.

[commit-bot: I haz the power, 2013-02-22 22:26:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/12334037/1

[Mostyn Bramley-Moore, 2013-02-23 01:36:56]

maruel reports that the android_dbg* failure was a temporary breakage in the
script and was already fixed.

[commit-bot: I haz the power, 2013-02-23 08:33:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/12334037/1

[commit-bot: I haz the power, 2013-02-23 14:24:03]

Change committed as 184320