Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: components/secure_display/elide_url.h

Issue 1233313005: Move elide_url to its own component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move to static library Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/secure_display/elide_url.h
diff --git a/chrome/browser/ui/elide_url.h b/components/secure_display/elide_url.h
similarity index 88%
rename from chrome/browser/ui/elide_url.h
rename to components/secure_display/elide_url.h
index b68267cb6d23568496f79644ed2e1aed49d80723..7d77b0453a4a0f8d47a52198f08162e1a6949823 100644
--- a/chrome/browser/ui/elide_url.h
+++ b/components/secure_display/elide_url.h
@@ -4,8 +4,8 @@
//
// This file defines utility functions for eliding URLs.
-#ifndef CHROME_BROWSER_UI_ELIDE_URL_H_
-#define CHROME_BROWSER_UI_ELIDE_URL_H_
+#ifndef COMPONENTS_SECURE_DISPLAY_ELIDE_URL_H_
+#define COMPONENTS_SECURE_DISPLAY_ELIDE_URL_H_
#include <string>
@@ -17,6 +17,11 @@ namespace gfx {
class FontList;
}
+namespace secure_display {
+
+// ElideUrl and Elide host require
+// gfx::GetStringWidthF which is not implemented in Android
+#if !defined(OS_ANDROID)
// This function takes a GURL object and elides it. It returns a string
// which composed of parts from subdomain, domain, path, filename and query.
// A "..." is added automatically at the end if the elided string is bigger
@@ -44,6 +49,7 @@ base::string16 ElideUrl(const GURL& url,
base::string16 ElideHost(const GURL& host_url,
const gfx::FontList& font_list,
float available_pixel_width);
+#endif // !defined(OS_ANDROID)
// This is a convenience function for formatting a URL in a concise and
// human-friendly way, to help users make security-related decisions (or in
@@ -61,4 +67,6 @@ base::string16 ElideHost(const GURL& host_url,
base::string16 FormatUrlForSecurityDisplay(const GURL& origin,
const std::string& languages);
-#endif // CHROME_BROWSER_UI_ELIDE_URL_H_
+} // namespace secure_display
+
+#endif // COMPONENTS_SECURE_DISPLAY_ELIDE_URL_H_

Powered by Google App Engine
This is Rietveld 408576698