Use Views Omnibox and Textfields by default on non-Aura Win.

Use Views Omnibox and Textfields by default on non-Aura Win.

Enable by default to expand dogfooding for release.
Users can --disable-views-textfield via commandline or about:flags.

File related Chrome UI (not web content) bugs against msw. Known issues:
http://crbug.com/?q=owner=msw@chromium.org

BUG=131660
TEST=Textfields work well enough on non-Aura Win.
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192702

[msw, 2013-02-27 19:55:05]

Hey Scott, please take a look; thanks.

[msw, 2013-02-27 20:34:47]

Actually, hold off while I investigate test failures; sorry.

[msw, 2013-04-05 19:06:56]

Hey Scott, please take a look, tests will pass after this CL lands:
https://codereview.chromium.org/13461032/

[sky, 2013-04-05 19:47:07]

LGTM

[commit-bot: I haz the power, 2013-04-06 02:29:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/12330177/23001

[commit-bot: I haz the power, 2013-04-06 04:51:04]

Change committed as 192702

[dcheng, 2013-04-07 02:13:00]

Is there any chance this is causing the test failure on Windows? They started
happening in
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/tr...
and have been happening since
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@DEPS
-
chromium.org&testType=interactive_ui_tests&tests=TabDragControllerTest.DragAllToSeparateWindowAndCancel:


Output from the test:
TabDragControllerTest.DragAllToSeparateWindowAndCancel: 
[784:3828:0405/231350:3496281:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231350:3496281:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231350:3496281:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231350:3496281:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231350:3496281:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231350:3496937:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231350:3496937:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231350:3496937:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231350:3496937:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231350:3496937:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231350:3497046:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231350:3497046:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231350:3497062:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231350:3497062:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231351:3497125:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231351:3497125:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
browser\ui\views\tabs\tab_drag_controller_interactive_uitest_win.cc(352): error:
Value of: tab_strip->IsDragSessionActive()
Actual: true
Expected: false
[784:3828:0405/231351:3497156:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231351:3497156:ERROR:native_textfield_views.cc(1013)] NOT
IMPLEMENTED
[784:3828:0405/231355:3501203:ERROR:textfield.h(162)] NOT IMPLEMENTED
Killed (timed out).

[msw, 2013-04-07 17:45:32]

On 2013/04/07 02:13:00, dcheng wrote:
> Is there any chance this is causing the test failure on Windows?
Yup, reverting fixed the test; I filed http://crrev.com/227444 and will fix
before re-landing.
Thanks for taking care of that and sorry for the inconvenience.