Simplify line editor choice in d8.

Simplify line editor choice in d8.


R=rossberg@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=13782

[rossberg, 2013-02-27 16:32:48]

LGTM with nit.

Frankly, this whole LineEditor code is weird, but I don't really care enough...

https://chromiumcodereview.appspot.com/12330171/diff/1/src/d8.cc
File src/d8.cc (right):

https://chromiumcodereview.appspot.com/12330171/diff/1/src/d8.cc#newcode131
src/d8.cc:131: if (current_ == NULL || current_->type_ < type) current_ = this;
Shouldn't you perhaps delete the current current_ here?

[Yang, 2013-02-28 12:59:57]

https://codereview.chromium.org/12330171/diff/1/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/12330171/diff/1/src/d8.cc#newcode131
src/d8.cc:131: if (current_ == NULL || current_->type_ < type) current_ = this;
On 2013/02/27 16:32:48, rossberg wrote:
> Shouldn't you perhaps delete the current current_ here?

Would that be safe? Both DumbLineEditor and ReadLineEditor are stack allocated.
Besides, deleting would only make sense if the DumbLineEditor happens to be
constructed first. Otherwise both would stay alive.

[rossberg, 2013-02-28 13:18:46]

On 2013/02/28 12:59:57, Yang wrote:
> https://codereview.chromium.org/12330171/diff/1/src/d8.cc
> File src/d8.cc (right):
> 
> https://codereview.chromium.org/12330171/diff/1/src/d8.cc#newcode131
> src/d8.cc:131: if (current_ == NULL || current_->type_ < type) current_ =
this;
> On 2013/02/27 16:32:48, rossberg wrote:
> > Shouldn't you perhaps delete the current current_ here?
> 
> Would that be safe? Both DumbLineEditor and ReadLineEditor are stack
allocated.
> Besides, deleting would only make sense if the DumbLineEditor happens to be
> constructed first. Otherwise both would stay alive.

Urgs, I see. The whole idea of auto-registering a reference to an object in its
constructor, when that object might be allocated on the stack (and in fact, is),
seems like an anti pattern to me. But whatever...

[Yang, 2013-02-28 17:40:30]

Committed patchset #3 manually as r13782 (presubmit successful).