Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 12330159: Android Findbugs: Remove TouchUtils as it shadows the name of the superclass (Closed)

Created:
7 years, 9 months ago by Kristian Monsen
Modified:
7 years, 9 months ago
Reviewers:
bulach, Isaac (away)
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org, Isaac (away), cjhopman
Visibility:
Public.

Description

Android Findbugs: Remove TouchUtils as it shadows the name of the superclass Can be removed after and alternative was introduced in https://codereview.chromium.org/12250031/ and all references to the old class has been changed to use the new class. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -217 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 chunk +0 lines, -1 line 0 comments Download
D content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TouchUtils.java View 1 chunk +0 lines, -216 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Kristian Monsen
Will bug someone else for the next one :-)
7 years, 9 months ago (2013-02-26 23:37:11 UTC) #1
bulach
lgtm I love red patches, keep them coming!
7 years, 9 months ago (2013-02-27 10:50:52 UTC) #2
Kristian Monsen
On 2013/02/27 10:50:52, bulach wrote: > lgtm > > I love red patches, keep them ...
7 years, 9 months ago (2013-02-27 18:27:02 UTC) #3
bulach
lgtm still my love is for red patches, i.e., deleting code.. :) for red bots, ...
7 years, 9 months ago (2013-02-28 09:04:32 UTC) #4
Isaac (away)
Findbugs is affected by stale files from previous incremental builds. If you are curious what ...
7 years, 9 months ago (2013-02-28 09:50:46 UTC) #5
Kristian Monsen
On 2013/02/28 09:50:46, Isaac wrote: > Findbugs is affected by stale files from previous incremental ...
7 years, 9 months ago (2013-02-28 22:25:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kristianm@chromium.org/12330159/1
7 years, 9 months ago (2013-02-28 22:28:51 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-01 01:59:13 UTC) #8
Message was sent while issue was closed.
Change committed as 185404

Powered by Google App Engine
This is Rietveld 408576698