Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 12330157: CRYPTO - Resolved comments from wtc. Used scoped_ptr<char[]> and (Closed)

Created:
7 years, 10 months ago by ramant (doing other things)
Modified:
7 years, 10 months ago
Reviewers:
wtc
CC:
chromium-reviews
Visibility:
Public.

Description

CRYPTO - Resolved comments from wtc. Used scoped_ptr<char[]> and deletion of virtual and removed and'ing with 0xFF. R=wtc@chromium.org TEST=crypt unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M crypto/hkdf.h View 1 chunk +1 line, -1 line 0 comments Download
M crypto/hkdf.cc View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
Hi wtc, Made the changes to address comments in the following CL. https://chromiumcodereview.appspot.com/12326029/#ps9004 PTAL. thanks ...
7 years, 10 months ago (2013-02-26 22:41:59 UTC) #1
wtc
LGTM. Thanks.
7 years, 10 months ago (2013-02-26 23:36:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/12330157/1
7 years, 10 months ago (2013-02-26 23:42:32 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-27 02:13:14 UTC) #4
Message was sent while issue was closed.
Change committed as 184832

Powered by Google App Engine
This is Rietveld 408576698