Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 12330155: Isolate check_internal.py to the .gypi files that need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Working version. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | google_apis/determine_use_official_keys.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_tests_unit.gypi
diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi
index 76fee091a83bba1fef2605fbdf741640740a2309..bdea7eb34069e53a5d95153f57a7b76b03d3ced4 100644
--- a/chrome/chrome_tests_unit.gypi
+++ b/chrome/chrome_tests_unit.gypi
@@ -445,6 +445,11 @@
'chrome_resources.gyp:chrome_resources',
'chrome_resources.gyp:chrome_strings',
],
+ # TODO(joi): Remove this section once the google_apis tests are
+ # a separate unit test binary.
+ 'includes': [
+ '../google_apis/determine_use_official_keys.gypi',
+ ],
'include_dirs': [
'..',
],
@@ -2389,11 +2394,6 @@
['exclude', '^browser/importer/'],
],
}],
- # TODO(joi): Remove from this file once separate
- # google_apis_unittests target is established.
- ['use_official_google_api_keys==1', {
- 'defines': ['USE_OFFICIAL_GOOGLE_API_KEYS=1'],
- }],
['enable_managed_users!=1', {
'sources/': [
['exclude', '^browser/managed_mode/'],
« no previous file with comments | « build/common.gypi ('k') | google_apis/determine_use_official_keys.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698